| Message ID | 1441014773-10902-6-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
On 31 August 2015 at 03:52, Bin Meng <bmeng.cn@gmail.com> wrote: > When building dm version of designware eth driver on a platform > with 64-bit phys_addr_t, it reports the following warnings: > > drivers/net/designware.c: In function 'designware_eth_probe': > drivers/net/designware.c:599:2: > warning: format '%lx' expects argument of type 'long unsigned int', > but argument 3 has type 'phys_addr_t' [-Wformat] > drivers/net/designware.c:600:21: > warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > drivers/net/designware.c:601:21: > warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > This commit fixes the build warnings. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > drivers/net/designware.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/net/designware.c b/drivers/net/designware.c index d9cb507..ae78d21 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -562,12 +562,12 @@ static int designware_eth_probe(struct udevice *dev) { struct eth_pdata *pdata = dev_get_platdata(dev); struct dw_eth_dev *priv = dev_get_priv(dev); + u32 iobase = pdata->iobase; int ret; - debug("%s, iobase=%lx, priv=%p\n", __func__, pdata->iobase, priv); - priv->mac_regs_p = (struct eth_mac_regs *)pdata->iobase; - priv->dma_regs_p = (struct eth_dma_regs *)(pdata->iobase + - DW_DMA_BASE_OFFSET); + debug("%s, iobase=%x, priv=%p\n", __func__, iobase, priv); + priv->mac_regs_p = (struct eth_mac_regs *)iobase; + priv->dma_regs_p = (struct eth_dma_regs *)(iobase + DW_DMA_BASE_OFFSET); priv->interface = pdata->phy_interface; dw_mdio_init(dev->name, priv->mac_regs_p);
When building dm version of designware eth driver on a platform with 64-bit phys_addr_t, it reports the following warnings: drivers/net/designware.c: In function 'designware_eth_probe': drivers/net/designware.c:599:2: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'phys_addr_t' [-Wformat] drivers/net/designware.c:600:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] drivers/net/designware.c:601:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] This commit fixes the build warnings. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- drivers/net/designware.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)