diff mbox

package/mke2img: set sparse_super for revision 1

Message ID 1440760370-61713-1-git-send-email-benoit@wsystem.com
State Accepted
Commit 225189803d9ecb07aef3f7f016376c7eb00dc44d
Headers show

Commit Message

Benoît Thébaudeau Aug. 28, 2015, 11:12 a.m. UTC
The sparse_super feature is more efficient in terms of speed and
available space, so set it by default if supported, i.e. for revision 1.

This gives a huge speed gain for large resize2fs operations, especially
for expansion.

Signed-off-by: Benoît Thébaudeau <benoit@wsystem.com>
---
 package/mke2img/mke2img | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Dec. 1, 2015, 10:31 p.m. UTC | #1
Benoît, All,

On 2015-08-28 13:12 +0200, Benoît Thébaudeau spake thusly:
> The sparse_super feature is more efficient in terms of speed and
> available space, so set it by default if supported, i.e. for revision 1.
> 
> This gives a huge speed gain for large resize2fs operations, especially
> for expansion.
> 
> Signed-off-by: Benoît Thébaudeau <benoit@wsystem.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/mke2img/mke2img | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/mke2img/mke2img b/package/mke2img/mke2img
> index 5e2f62f..806cb1f 100755
> --- a/package/mke2img/mke2img
> +++ b/package/mke2img/mke2img
> @@ -76,7 +76,7 @@ main() {
>  
>      # Upgrade to rev1 if needed
>      if [ ${rev} -ge 1 ]; then
> -        tune2fs_O_opts+=",filetype"
> +        tune2fs_O_opts+=",filetype,sparse_super"
>      fi
>  
>      # Add a journal for ext3 and above
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Dec. 29, 2015, 9:03 p.m. UTC | #2
>>>>> "Benoît" == Benoît Thébaudeau <benoit@wsystem.com> writes:

> The sparse_super feature is more efficient in terms of speed and
> available space, so set it by default if supported, i.e. for revision 1.

> This gives a huge speed gain for large resize2fs operations, especially
> for expansion.

> Signed-off-by: Benoît Thébaudeau <benoit@wsystem.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/mke2img/mke2img b/package/mke2img/mke2img
index 5e2f62f..806cb1f 100755
--- a/package/mke2img/mke2img
+++ b/package/mke2img/mke2img
@@ -76,7 +76,7 @@  main() {
 
     # Upgrade to rev1 if needed
     if [ ${rev} -ge 1 ]; then
-        tune2fs_O_opts+=",filetype"
+        tune2fs_O_opts+=",filetype,sparse_super"
     fi
 
     # Add a journal for ext3 and above