diff mbox

fix --with-cpu for sh targets

Message ID 20150827040245.GV32742@brightrain.aerifal.cx
State New
Headers show

Commit Message

Rich Felker Aug. 27, 2015, 4:02 a.m. UTC 
A missing * in the pattern for sh targets prevents the --with-cpu
configure option from being accepted for certain targets (e.g. ones
with explicit endianness, like sh2eb).

The latest config.sub should also be pulled from upstream since it has
a fix for related issues.

Rich

Comments

Kaz Kojima Aug. 30, 2015, 10:41 a.m. UTC | #1 
Rich Felker <dalias@libc.org> wrote:
> A missing * in the pattern for sh targets prevents the --with-cpu
> configure option from being accepted for certain targets (e.g. ones
> with explicit endianness, like sh2eb).

Looks good to me, though we need the trunk patch first with
the appropriate ChangeLog entry.
Oleg, do you have any opinions?

Regards,
	kaz
Oleg Endo Aug. 30, 2015, 4:02 p.m. UTC | #2 
On 30 Aug 2015, at 19:41, Kaz Kojima <kkojima@rr.iij4u.or.jp> wrote:

> Rich Felker <dalias@libc.org> wrote:
>> A missing * in the pattern for sh targets prevents the --with-cpu
>> configure option from being accepted for certain targets (e.g. ones
>> with explicit endianness, like sh2eb).
> 
> Looks good to me, though we need the trunk patch first with
> the appropriate ChangeLog entry.
> Oleg, do you have any opinions?

No, I don't.  If it doesn't break anything and fixes some inconvenience, please go ahead.

Cheers,
Oleg
diff mbox

Patch

--- gcc-5.2.0.orig/gcc/config.gcc
+++ gcc-5.2.0/gcc/config.gcc
@@ -4096,7 +4099,7 @@ 
 		esac
 		;;
 
-	sh[123456ble]-*-* | sh-*-*)
+	sh[123456ble]*-*-* | sh-*-*)
 		supported_defaults="cpu"
 		case "`echo $with_cpu | tr ABCDEFGHIJKLMNOPQRSTUVWXYZ_ abcdefghijklmnopqrstuvwxyz- | sed s/sh/m/`" in
 		"" | m1 | m2 | m2e | m3 | m3e | m4 | m4-single | m4-single-only | m4-nofpu )