From patchwork Tue Apr 27 12:34:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 51072 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 72545B7D63 for ; Tue, 27 Apr 2010 23:10:16 +1000 (EST) Received: from localhost ([127.0.0.1]:40787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6kUI-0006Z4-63 for incoming@patchwork.ozlabs.org; Tue, 27 Apr 2010 09:06:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6k1i-00068t-JG for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:34 -0400 Received: from [140.186.70.92] (port=51450 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6k1g-000688-Tf for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6k1f-0002qx-Jr for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48026) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6k1f-0002qo-93 for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:31 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3RCaTtb021365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Apr 2010 08:36:29 -0400 Received: from localhost (vpn-238-78.phx2.redhat.com [10.3.238.78]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3RCaRYv007870; Tue, 27 Apr 2010 08:36:28 -0400 From: Amit Shah To: Anthony Liguori Date: Tue, 27 Apr 2010 18:04:08 +0530 Message-Id: <1272371652-23087-15-git-send-email-amit.shah@redhat.com> In-Reply-To: <1272371652-23087-14-git-send-email-amit.shah@redhat.com> References: <1272371652-23087-1-git-send-email-amit.shah@redhat.com> <1272371652-23087-2-git-send-email-amit.shah@redhat.com> <1272371652-23087-3-git-send-email-amit.shah@redhat.com> <1272371652-23087-4-git-send-email-amit.shah@redhat.com> <1272371652-23087-5-git-send-email-amit.shah@redhat.com> <1272371652-23087-6-git-send-email-amit.shah@redhat.com> <1272371652-23087-7-git-send-email-amit.shah@redhat.com> <1272371652-23087-8-git-send-email-amit.shah@redhat.com> <1272371652-23087-9-git-send-email-amit.shah@redhat.com> <1272371652-23087-10-git-send-email-amit.shah@redhat.com> <1272371652-23087-11-git-send-email-amit.shah@redhat.com> <1272371652-23087-12-git-send-email-amit.shah@redhat.com> <1272371652-23087-13-git-send-email-amit.shah@redhat.com> <1272371652-23087-14-git-send-email-amit.shah@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Amit Shah , Avi Kivity , qemu list , Juan Quintela Subject: [Qemu-devel] [PATCH v6 14/18] virtio-serial: Handle scatter/gather input from the guest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Current guests don't send more than one iov but it can change later. Ensure we handle that case. Signed-off-by: Amit Shah CC: Avi Kivity --- hw/virtio-serial-bus.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index b8410c3..3053a35 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -351,7 +351,8 @@ static void handle_output(VirtIODevice *vdev, VirtQueue *vq) while (virtqueue_pop(vq, &elem)) { VirtIOSerialPort *port; - size_t ret; + uint8_t *buf; + size_t ret, buf_size; port = find_port_by_vq(vser, vq); if (!port) { @@ -374,9 +375,12 @@ static void handle_output(VirtIODevice *vdev, VirtQueue *vq) goto next_buf; } - /* The guest always sends only one sg */ - ret = port->info->have_data(port, elem.out_sg[0].iov_base, - elem.out_sg[0].iov_len); + buf_size = iov_size(elem.out_sg, elem.out_num); + buf = qemu_malloc(buf_size); + ret = iov_to_buf(elem.out_sg, elem.out_num, buf, 0, buf_size); + + ret = port->info->have_data(port, buf, ret); + qemu_free(buf); next_buf: virtqueue_push(vq, &elem, ret);