From patchwork Tue Apr 27 12:34:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 51067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7F812B7D6C for ; Tue, 27 Apr 2010 22:57:34 +1000 (EST) Received: from localhost ([127.0.0.1]:43481 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6kLV-0004lp-7o for incoming@patchwork.ozlabs.org; Tue, 27 Apr 2010 08:57:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6k1b-00065e-CV for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:27 -0400 Received: from [140.186.70.92] (port=51358 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6k1W-00063W-Vc for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6k1S-0002mz-DF for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1163) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6k1S-0002mo-52 for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:18 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3RCaGH8009065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Apr 2010 08:36:16 -0400 Received: from localhost (vpn-238-78.phx2.redhat.com [10.3.238.78]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3RCaErF021699; Tue, 27 Apr 2010 08:36:15 -0400 From: Amit Shah To: Anthony Liguori Date: Tue, 27 Apr 2010 18:04:03 +0530 Message-Id: <1272371652-23087-10-git-send-email-amit.shah@redhat.com> In-Reply-To: <1272371652-23087-9-git-send-email-amit.shah@redhat.com> References: <1272371652-23087-1-git-send-email-amit.shah@redhat.com> <1272371652-23087-2-git-send-email-amit.shah@redhat.com> <1272371652-23087-3-git-send-email-amit.shah@redhat.com> <1272371652-23087-4-git-send-email-amit.shah@redhat.com> <1272371652-23087-5-git-send-email-amit.shah@redhat.com> <1272371652-23087-6-git-send-email-amit.shah@redhat.com> <1272371652-23087-7-git-send-email-amit.shah@redhat.com> <1272371652-23087-8-git-send-email-amit.shah@redhat.com> <1272371652-23087-9-git-send-email-amit.shah@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Amit Shah , qemu list , Juan Quintela Subject: [Qemu-devel] [PATCH v6 09/18] virtio-serial: Propagate errors in initialising ports / devices in guest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org If adding of ports or devices in the guest fails we can send out a QMP event so that management software can deal with it. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index c77ea4f..3a09f0d 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -223,6 +223,11 @@ static void handle_control_message(VirtIOSerial *vser, void *buf) switch(cpkt.event) { case VIRTIO_CONSOLE_DEVICE_READY: + if (!cpkt.value) { + error_report("virtio-serial-bus: Guest failure in adding device %s\n", + vser->bus->qbus.name); + break; + } /* * The device is up, we can now tell the device about all the * ports we have here. @@ -233,6 +238,11 @@ static void handle_control_message(VirtIOSerial *vser, void *buf) break; case VIRTIO_CONSOLE_PORT_READY: + if (!cpkt.value) { + error_report("virtio-serial-bus: Guest failure in adding port %u for device %s\n", + port->id, vser->bus->qbus.name); + break; + } /* * Now that we know the guest asked for the port name, we're * sure the guest has initialised whatever state is necessary