Message ID | CAHA+R7Mr03t5NQMhdeY0ygHM5+nzMecoQL7TFOMNmR1+OgCQ7g@mail.gmail.com |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show |
On Mon, 24 Aug 2015 23:02:02 -0700, Cong Wang wrote: > Hi, Jiri, > > In your commit 61adedf3e3f1d3f032c5a6a299978d91eff6d555 ("route: move > lwtunnel state to dst_entry"), how the hell could the following piece > be correct? :-/ It's not. > I cooked a _quick_ patch to fix it. I can send it formally if it looks > good to you, if not, feel free to send a better fix before me. > > diff --git a/net/core/dst.c b/net/core/dst.c > index 50dcdbb..477035e 100644 > --- a/net/core/dst.c > +++ b/net/core/dst.c > @@ -262,11 +262,12 @@ again: > if (dst->dev) > dev_put(dst->dev); > > + lwtstate_put(dst->lwtstate); > + > if (dst->flags & DST_METADATA) > kfree(dst); > else > kmem_cache_free(dst->ops->kmem_cachep, dst); > - lwtstate_put(dst->lwtstate); > > dst = child; > if (dst) { Looks good. You can add my Acked-by: Jiri Benc <jbenc@redhat.com> when you submit it. Thanks a lot, Jiri
diff --git a/net/core/dst.c b/net/core/dst.c index 50dcdbb..477035e 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -262,11 +262,12 @@ again: if (dst->dev) dev_put(dst->dev); + lwtstate_put(dst->lwtstate); + if (dst->flags & DST_METADATA) kfree(dst); else kmem_cache_free(dst->ops->kmem_cachep, dst); - lwtstate_put(dst->lwtstate); dst = child; if (dst) {