| Message ID | 1440440620-25937-48-git-send-email-damien.lespiau@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Aug 24, 2015 at 07:23:36PM +0100, Damien Lespiau wrote: > Wolfram wanted a small usability improvement that's easy to add: placing > the cursor automatically in the user name field when loading the login > page. > > Suggested-by: Wolfram Sang <wsa@the-dreams.de> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Can this be applied as-is right now? So we can have this immediate benefit while the whole series gets more testing/review? Thanks, Wolfram
On Wed, Aug 26, 2015 at 09:21:30PM +0200, Wolfram Sang wrote: > On Mon, Aug 24, 2015 at 07:23:36PM +0100, Damien Lespiau wrote: > > Wolfram wanted a small usability improvement that's easy to add: placing > > the cursor automatically in the user name field when loading the login > > page. > > > > Suggested-by: Wolfram Sang <wsa@the-dreams.de> > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > Can this be applied as-is right now? So we can have this immediate > benefit while the whole series gets more testing/review? FWIW, this change depends on patch 1/51, so both would have to be merged.
> Wolfram wanted a small usability improvement that's easy to add: placing > the cursor automatically in the user name field when loading the login > page. > > Suggested-by: Wolfram Sang <wsa@the-dreams.de> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Obvious usability improvements. If it depends on 1/51, maybe combine with that/put in sequence with that? Acked-by: Stephen Finucane <stephen.finucane@intel.com>
diff --git a/patchwork/templates/patchwork/login.html b/patchwork/templates/patchwork/login.html index 2dfc2a7..1f000e7 100644 --- a/patchwork/templates/patchwork/login.html +++ b/patchwork/templates/patchwork/login.html @@ -3,6 +3,13 @@ {% block title %}Login{% endblock %} {% block heading %}Login{% endblock %} +{% block headers %} + <script type="text/javascript"> + $(function() { + $('#id_username').focus() + }); + </script> +{% endblock %} {% block body %} <form method="post">
Wolfram wanted a small usability improvement that's easy to add: placing the cursor automatically in the user name field when loading the login page. Suggested-by: Wolfram Sang <wsa@the-dreams.de> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- patchwork/templates/patchwork/login.html | 7 +++++++ 1 file changed, 7 insertions(+)