| Message ID | 1440440620-25937-4-git-send-email-damien.lespiau@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Bootstrap is a bit of a hammer and probably unnecessary for a site design as simple as this. It's a mostly-static website with little to no CSS3 and only the bare minimum of JavaScript. I also think it's a fair assumption that people using patchwork are working on PC-class devices with an evergreen browser. This means we're not taking advantage of the things that Bootstrap offers: responsive design, mobile first design, browser compatibility etc. I can find countless blogs that would suggest Bootstrap is pretty much unneeded in this case.
*However*, while I dabble in webdev I am by no means a front-end developer. I may also be suffering from Not Invented Here (NIH) syndrome. Updating the site with a minimal amount of frameworks (say, HTML5 Bootstrap + JQuery + custom CSS) may well be more trouble than it's worth. For this reason, and this reason alone:
Acked-by: Stephen Finucane <stephen.finucane@intel.com>
> Bootstrap is a bit of a hammer and probably unnecessary for a site design > as simple as this. It's a mostly-static website with little to no CSS3 and > only the bare minimum of JavaScript. I also think it's a fair assumption > that people using patchwork are working on PC-class devices with an > evergreen browser. This means we're not taking advantage of the things that > Bootstrap offers: responsive design, mobile first design, browser > compatibility etc. I can find countless blogs that would suggest Bootstrap > is pretty much unneeded in this case. This probably sums up my thoughts better than I can. It's an opinion piece though and should be treated as such: http://fourword.fourkitchens.com/article/you-dont-need-bootstrap > *However*, while I dabble in webdev I am by no means a front-end developer. > I may also be suffering from Not Invented Here (NIH) syndrome. Updating the > site with a minimal amount of frameworks (say, HTML5 Bootstrap + JQuery + > custom CSS) may well be more trouble than it's worth. For this reason, and > this reason alone: > > Acked-by: Stephen Finucane <stephen.finucane@intel.com>
On Wed, Sep 09, 2015 at 02:47:29PM +0100, Finucane, Stephen wrote: > > Bootstrap is a bit of a hammer and probably unnecessary for a site design > > as simple as this. It's a mostly-static website with little to no CSS3 and > > only the bare minimum of JavaScript. I also think it's a fair assumption > > that people using patchwork are working on PC-class devices with an > > evergreen browser. This means we're not taking advantage of the things that > > Bootstrap offers: responsive design, mobile first design, browser > > compatibility etc. I can find countless blogs that would suggest Bootstrap > > is pretty much unneeded in this case. > > This probably sums up my thoughts better than I can. It's an opinion piece though and should be treated as such: > > http://fourword.fourkitchens.com/article/you-dont-need-bootstrap As with everything, you can find opinion pieces on both sides, try searching "why should I use bootsrap blog"... The more important thing is where we want to go. For me, I want more modern UI, edit fields in place instead of the forms patchwork has right now, do ajaxy things and be usesable from my mobile phone so I can quickly review things on the go. All that need a solid CSS component base and plenty of javascript. Hence bootstrap.
diff --git a/templates/base.html b/templates/base.html index 48ea4f0..3d07504 100644 --- a/templates/base.html +++ b/templates/base.html @@ -6,9 +6,18 @@ <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> <title>{% block title %}Patchwork{% endblock %} - Patchwork</title> + <link rel="stylesheet" type="text/css" href="{% static "css/bootstrap.min.css" %}"/> <link rel="stylesheet" type="text/css" href="{% static "css/style.css" %}"/> <script type="text/javascript" src="{% static "js/common.js" %}"></script> <script type="text/javascript" src="{% static "js/jquery-1.10.1.min.js" %}"></script> + <!-- IE8 support of HTML5 elements and media queries --> + <!-- WARNING: Respond.js doesn't work if you view the page via file:// --> + <!--[if lt IE 9]> + <script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"> + </script> + <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script> + <![endif]--> + <script type="text/javascript" src="{% static "js/bootstrap.min.js" %}"></script> {% block headers %}{% endblock %} </head> <body>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- templates/base.html | 9 +++++++++ 1 file changed, 9 insertions(+)