Patchwork fix whitespace bogon in some versions of make

login
register
mail settings
Submitter Nathan Froyd
Date April 26, 2010, 9:52 p.m.
Message ID <1272318743-17113-1-git-send-email-froydnj@codesourcery.com>
Download mbox | patch
Permalink /patch/51009/
State New
Headers show

Comments

Nathan Froyd - April 26, 2010, 9:52 p.m.
With three different make binaries I have available, configuring a
pristine QEMU tree and attempting to make gives the cryptic:

Makefile:27: *** missing separator.  Stop.

This patch fixes it (presumably because it makes the output of
`set-vpath' be an empty string, rather than a bit of whitespace), but I
don't understand why this hasn't been a problem for other folks before.

Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
---
 rules.mak |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Paolo Bonzini - April 27, 2010, 8:09 a.m.
On 04/26/2010 11:52 PM, Nathan Froyd wrote:
> With three different make binaries I have available, configuring a
> pristine QEMU tree and attempting to make gives the cryptic:
>
> Makefile:27: *** missing separator.  Stop.
>
> This patch fixes it (presumably because it makes the output of
> `set-vpath' be an empty string, rather than a bit of whitespace), but I
> don't understand why this hasn't been a problem for other folks before.
>
> Signed-off-by: Nathan Froyd<froydnj@codesourcery.com>
> ---
>   rules.mak |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 5941b73..7e10432 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -40,7 +40,7 @@ cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
>                 >/dev/null 2>&1&&  echo OK), $2, $3)
>
>   VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
> -set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES), $(eval vpath $(PATTERN) $1)))
> +set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
>
>   # Generate timestamp files for .h include files

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo
Anthony Liguori - May 3, 2010, 6:06 p.m.
On 04/26/2010 04:52 PM, Nathan Froyd wrote:
> With three different make binaries I have available, configuring a
> pristine QEMU tree and attempting to make gives the cryptic:
>
> Makefile:27: *** missing separator.  Stop.
>
> This patch fixes it (presumably because it makes the output of
> `set-vpath' be an empty string, rather than a bit of whitespace), but I
> don't understand why this hasn't been a problem for other folks before.
>
> Signed-off-by: Nathan Froyd<froydnj@codesourcery.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   rules.mak |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 5941b73..7e10432 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -40,7 +40,7 @@ cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
>                 >/dev/null 2>&1&&  echo OK), $2, $3)
>
>   VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
> -set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES), $(eval vpath $(PATTERN) $1)))
> +set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
>
>   # Generate timestamp files for .h include files
>
>

Patch

diff --git a/rules.mak b/rules.mak
index 5941b73..7e10432 100644
--- a/rules.mak
+++ b/rules.mak
@@ -40,7 +40,7 @@  cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
               >/dev/null 2>&1 && echo OK), $2, $3)
 
 VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
-set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES), $(eval vpath $(PATTERN) $1)))
+set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
 
 # Generate timestamp files for .h include files