From patchwork Mon Apr 26 15:47:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 50971 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 70A2FB7D40 for ; Tue, 27 Apr 2010 02:05:29 +1000 (EST) Received: from localhost ([127.0.0.1]:59539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6Qfe-0002hh-U9 for incoming@patchwork.ozlabs.org; Mon, 26 Apr 2010 11:56:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6QY0-0000ri-Ut for qemu-devel@nongnu.org; Mon, 26 Apr 2010 11:48:37 -0400 Received: from [140.186.70.92] (port=34738 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6QXz-0000r8-NX for qemu-devel@nongnu.org; Mon, 26 Apr 2010 11:48:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6QXx-0007G7-V1 for qemu-devel@nongnu.org; Mon, 26 Apr 2010 11:48:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41640) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6QXx-0007G1-JK for qemu-devel@nongnu.org; Mon, 26 Apr 2010 11:48:33 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3QFmWgs012092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Apr 2010 11:48:32 -0400 Received: from localhost (vpn-8-143.rdu.redhat.com [10.11.8.143]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3QFmVoM024059; Mon, 26 Apr 2010 11:48:32 -0400 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Mon, 26 Apr 2010 12:47:28 -0300 Message-Id: <1272296853-30285-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1272296853-30285-1-git-send-email-lcapitulino@redhat.com> References: <1272296853-30285-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 4/9] QMP: Check "arguments" member's type X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Otherwise the following input crashes QEMU: { "execute": "migrate", "arguments": "tcp:0:4446" } Signed-off-by: Luiz Capitulino --- monitor.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 0611b29..ef84298 100644 --- a/monitor.c +++ b/monitor.c @@ -4437,6 +4437,9 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens) obj = qdict_get(input, "arguments"); if (!obj) { args = qdict_new(); + } else if (qobject_type(obj) != QTYPE_QDICT) { + qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "arguments", "object"); + goto err_input; } else { args = qobject_to_qdict(obj); QINCREF(args);