Patchwork cxgb3: Wait longer for control packets on initialization

login
register
mail settings
Submitter Andre Detsch
Date April 26, 2010, 3:38 p.m.
Message ID <201004261238.27919.adetsch@br.ibm.com>
Download mbox | patch
Permalink /patch/50968/
State Accepted
Delegated to: David Miller
Headers show

Comments

Andre Detsch - April 26, 2010, 3:38 p.m.
In some Power7 platforms, when using VIOS (Virtual I/O Server), we
need to wait longer for control packets to finish transfer during
initialization.
Without this change, initialization may fail prematurely.

Signed-off-by: Wen Xiong <wenxiong@us.ibm.com>
Signed-off-by: Andre Detsch <adetsch@br.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Divy Le Ray - April 27, 2010, 2:16 a.m.
Andre Detsch wrote:
> In some Power7 platforms, when using VIOS (Virtual I/O Server), we
> need to wait longer for control packets to finish transfer during
> initialization.
> Without this change, initialization may fail prematurely.
>
> Signed-off-by: Wen Xiong <wenxiong@us.ibm.com>
> Signed-off-by: Andre Detsch <adetsch@br.ibm.com>
>   

Acked-by: Divy Le Ray <divy@chelsio.com>

> Index: linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c
> ===================================================================
> --- linux-2.6.34-rc5.orig/drivers/net/cxgb3/cxgb3_main.c	2010-04-23 18:59:43.000000000 -0300
> +++ linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c	2010-04-23 18:59:55.000000000 -0300
> @@ -439,7 +439,7 @@ static void free_irq_resources(struct ad
>  static int await_mgmt_replies(struct adapter *adap, unsigned long init_cnt,
>  			      unsigned long n)
>  {
> -	int attempts = 5;
> +	int attempts = 10;
>
>  	while (adap->sge.qs[0].rspq.offload_pkts < init_cnt + n) {
>  		if (!--attempts)
>   

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 27, 2010, 5:18 p.m.
From: Divy Le Ray <divy@chelsio.com>
Date: Mon, 26 Apr 2010 19:16:28 -0700

> Andre Detsch wrote:
>> In some Power7 platforms, when using VIOS (Virtual I/O Server), we
>> need to wait longer for control packets to finish transfer during
>> initialization.
>> Without this change, initialization may fail prematurely.
>>
>> Signed-off-by: Wen Xiong <wenxiong@us.ibm.com>
>> Signed-off-by: Andre Detsch <adetsch@br.ibm.com>
>>   
> 
> Acked-by: Divy Le Ray <divy@chelsio.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c
===================================================================
--- linux-2.6.34-rc5.orig/drivers/net/cxgb3/cxgb3_main.c	2010-04-23 18:59:43.000000000 -0300
+++ linux-2.6.34-rc5/drivers/net/cxgb3/cxgb3_main.c	2010-04-23 18:59:55.000000000 -0300
@@ -439,7 +439,7 @@  static void free_irq_resources(struct ad
 static int await_mgmt_replies(struct adapter *adap, unsigned long init_cnt,
 			      unsigned long n)
 {
-	int attempts = 5;
+	int attempts = 10;

 	while (adap->sge.qs[0].rspq.offload_pkts < init_cnt + n) {
 		if (!--attempts)