diff mbox

Don't use -Wno-strict-prototypes in timezone/

Message ID alpine.DEB.2.10.1508201952190.994@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Aug. 20, 2015, 7:52 p.m. UTC 
The current timezone/ code from tzcode doesn't need
-Wno-strict-prototypes.  This patch removes it from the CFLAGS
settings in timezone/Makefile.

Tested for x86_64 that glibc still builds OK with the patch applied.

2015-08-20  Joseph Myers  <joseph@codesourcery.com>

	* timezone/Makefile (CFLAGS-zdump.c): Remove
	-Wno-strict-prototypes.
	(CFLAGS-zic.c): Likewise.
	(CFLAGS-ialloc.c): Likewise.
	(CFLAGS-scheck.c): Likewise.

Comments

Paul Eggert Aug. 20, 2015, 8 p.m. UTC | #1 
Joseph Myers wrote:
> The current timezone/ code from tzcode doesn't need
> -Wno-strict-prototypes.  This patch removes it from the CFLAGS
> settings in timezone/Makefile.

Looks good to me, thanks.

By the way, ialloc.c and scheck.c have been removed in the current tzcode 
release, so that part of the change is to obsolete cruft.  But removing the 
cruft can wait until we get around to syncing from tzcode again.
Joseph Myers Aug. 20, 2015, 8:58 p.m. UTC | #2 
On Thu, 20 Aug 2015, Paul Eggert wrote:

> Joseph Myers wrote:
> > The current timezone/ code from tzcode doesn't need
> > -Wno-strict-prototypes.  This patch removes it from the CFLAGS
> > settings in timezone/Makefile.
> 
> Looks good to me, thanks.

Thanks, I've committed it.

> By the way, ialloc.c and scheck.c have been removed in the current tzcode
> release, so that part of the change is to obsolete cruft.  But removing the
> cruft can wait until we get around to syncing from tzcode again.

An update to a newer tzcode release (not a git version, and with no local 
changes to the files taken from tzcode) should be routine, although the 
Makefile changes would need to be reviewed.
diff mbox

Patch

diff --git a/timezone/Makefile b/timezone/Makefile
index d2abdec..81d4a3e 100644
--- a/timezone/Makefile
+++ b/timezone/Makefile
@@ -61,11 +61,10 @@  tz-cflags = -DTZDIR='"$(zonedir)"' \
 	    -DTZDEFRULES='"$(posixrules-file)"' \
 	    -DTM_GMTOFF=tm_gmtoff -DTM_ZONE=tm_zone
 
-CFLAGS-zdump.c = -fwrapv -Wno-strict-prototypes -DNOID $(tz-cflags) \
-		 -DHAVE_GETTEXT
-CFLAGS-zic.c = -Wno-strict-prototypes -DNOID $(tz-cflags) -DHAVE_GETTEXT
-CFLAGS-ialloc.c = -Wno-strict-prototypes -DNOID -DHAVE_GETTEXT
-CFLAGS-scheck.c = -Wno-strict-prototypes -DNOID -DHAVE_GETTEXT
+CFLAGS-zdump.c = -fwrapv -DNOID $(tz-cflags) -DHAVE_GETTEXT
+CFLAGS-zic.c = -DNOID $(tz-cflags) -DHAVE_GETTEXT
+CFLAGS-ialloc.c = -DNOID -DHAVE_GETTEXT
+CFLAGS-scheck.c = -DNOID -DHAVE_GETTEXT
 
 # We have to make sure the data for testing the tz functions is available.
 # Don't add leapseconds here since test-tz made checks that work only without