Patchwork [2/2] pata_scc: kill useless check in scc_postreset()

login
register
mail settings
Submitter Sergei Shtylyov
Date April 24, 2010, 4:29 p.m.
Message ID <201004242029.59003.sshtylyov@ru.mvista.com>
Download mbox | patch
Permalink /patch/50912/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Sergei Shtylyov - April 24, 2010, 4:29 p.m.
The device control register exists and its address is set by scc_setup_ports(),
hence the check is useless...

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
The patch is against the recent Linus' tree.

 drivers/ata/pata_scc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: linux-2.6/drivers/ata/pata_scc.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_scc.c
+++ linux-2.6/drivers/ata/pata_scc.c
@@ -903,8 +903,7 @@  static void scc_postreset(struct ata_lin
 	}
 
 	/* set up device control */
-	if (ap->ioaddr.ctl_addr)
-		out_be32(ap->ioaddr.ctl_addr, ap->ctl);
+	out_be32(ap->ioaddr.ctl_addr, ap->ctl);
 
 	DPRINTK("EXIT\n");
 }