| Message ID | 87d1yi9rn9.fsf@e105548-lin.cambridge.arm.com |
|---|---|
| State | New |
| Headers | show |
[Sorry for the delay] > gen_rtx_CONST_VECTOR ensures that there is a single instance of: > > (const_vector:M [(const_int -1) ... (const_int -1)]) > > for each M, so pointer equality with CONSTM1_RTX is enough. Also, > HOST_BITS_PER_WIDE_INT == 32 is doubly dead: HOST_WIDE_INT is always > 64 bits now, and we always use const_int rather than const_double > or const_wide_int for all-ones values (or any other value that > fits in a signed HOST_WIDE_INT). > > This seemed like a better fix than using the helper functions > that I'm about to post. > > Tested with a cross-compiler and ensured that the predicate was > still accepting all (-)1 values. OK to install? > > Thanks, > Richard > > gcc/ > * config/sparc/predicates.md (const_all_ones_operand): Use > CONSTM1_RTX to simplify definition. OK, thanks.
diff --git a/gcc/config/sparc/predicates.md b/gcc/config/sparc/predicates.md index 88537c6..aa45f8e 100644 --- a/gcc/config/sparc/predicates.md +++ b/gcc/config/sparc/predicates.md @@ -27,31 +27,9 @@ ;; Return true if the integer representation of OP is ;; all-ones. (define_predicate "const_all_ones_operand" - (match_code "const_int,const_double,const_vector") -{ - if (GET_CODE (op) == CONST_INT && INTVAL (op) == -1) - return true; -#if HOST_BITS_PER_WIDE_INT == 32 - if (GET_CODE (op) == CONST_DOUBLE - && GET_MODE (op) == VOIDmode - && CONST_DOUBLE_HIGH (op) == ~(HOST_WIDE_INT)0 - && CONST_DOUBLE_LOW (op) == ~(HOST_WIDE_INT)0) - return true; -#endif - if (GET_CODE (op) == CONST_VECTOR) - { - int i, num_elem = CONST_VECTOR_NUNITS (op); - - for (i = 0; i < num_elem; i++) - { - rtx n = CONST_VECTOR_ELT (op, i); - if (! const_all_ones_operand (n, mode)) - return false; - } - return true; - } - return false; -}) + (and (match_code "const_int,const_double,const_vector") + (match_test "INTEGRAL_MODE_P (GET_MODE (op))") + (match_test "op == CONSTM1_RTX (GET_MODE (op))"))) ;; Return true if OP is the integer constant 4096. (define_predicate "const_4096_operand"