[COMMITTED] nptl: Document crash due to incorrect use of locks
diff mbox

Message ID 55D577A9.8040306@redhat.com
State New
Headers show

Commit Message

Florian Weimer Aug. 20, 2015, 6:46 a.m. UTC

Patch
diff mbox

From cd4e69ed3e4b2d51ebd3dfaa0730793cf913de77 Mon Sep 17 00:00:00 2001
Message-Id: <cd4e69ed3e4b2d51ebd3dfaa0730793cf913de77.1440053096.git.fweimer@redhat.com>
From: Florian Weimer <fweimer@redhat.com>
Date: Thu, 20 Aug 2015 08:44:09 +0200
Subject: [PATCH] nptl: Document crash due to incorrect use of locks
To: libc-alpha@sourceware.org

---
 ChangeLog           | 5 +++++
 sysdeps/x86/elide.h | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index b3c9892..c0f7f5d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@ 
+2015-08-20  Florian Weimer  <fweimer@redhat.com>
+
+	* sysdeps/x86/elide.h (ELIDE_UNLOCK): Document crash due to
+	incorrect use.
+
 2015-08-19  Joseph Myers  <joseph@codesourcery.com>
 
 	[BZ #18370]
diff --git a/sysdeps/x86/elide.h b/sysdeps/x86/elide.h
index 47e89cf..6e53288 100644
--- a/sysdeps/x86/elide.h
+++ b/sysdeps/x86/elide.h
@@ -93,7 +93,9 @@  elision_adapt(signed char *adapt_count, unsigned int status)
     ret;						\
     })
 
-/* Returns true if lock defined by IS_LOCK_FREE was elided.  */
+/* Returns true if lock defined by IS_LOCK_FREE was elided.  The call
+   to _xend crashes if the application incorrectly tries to unlock a
+   lock which has not been locked.  */
 
 #define ELIDE_UNLOCK(is_lock_free)		\
   ({						\
-- 
2.4.3