[1/2] pinctrl: sh-pfc: r8a7794: add USB pin groups
diff mbox

Message ID 6436990.f6AZfhkFnG@wasted.cogentembedded.com
State New
Headers show

Commit Message

Sergei Shtylyov Aug. 18, 2015, 10:26 p.m. UTC
From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>

Add USB0/1 pin groups to R8A7794 PFC driver.

Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
[Sergei: rebased, renamed, added changelog.]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/pinctrl/sh-pfc/pfc-r8a7794.c |   30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Laurent Pinchart Aug. 19, 2015, 9:14 p.m. UTC | #1
Hi Sergei,

Thank you for the patch.

On Wednesday 19 August 2015 01:26:55 Sergei Shtylyov wrote:
> From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> 
> Add USB0/1 pin groups to R8A7794 PFC driver.
> 
> Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> [Sergei: rebased, renamed, added changelog.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/pinctrl/sh-pfc/pfc-r8a7794.c |   30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> ===================================================================
> --- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> +++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> @@ -2770,6 +2770,24 @@ static const unsigned int sdhi2_wp_pins[
>  static const unsigned int sdhi2_wp_mux[] = {
>  	SD2_WP_MARK,
>  };
> +/* - USB0
> ------------------------------------------------------------------- */
> +static const unsigned int usb0_pins[] = {
> +	RCAR_GP_PIN(5, 24), /* PWEN */
> +	RCAR_GP_PIN(5, 25), /* OVC */
> +};
> +static const unsigned int usb0_mux[] = {
> +	USB0_PWEN_MARK,
> +	USB0_OVC_MARK,
> +};
> +/* - USB1
> ------------------------------------------------------------------- */
> +static const unsigned int usb1_pins[] = {
> +	RCAR_GP_PIN(5, 26), /* PWEN */
> +	RCAR_GP_PIN(5, 27), /* OVC */
> +};
> +static const unsigned int usb1_mux[] = {
> +	USB1_PWEN_MARK,
> +	USB1_OVC_MARK,
> +};
> 
>  static const struct sh_pfc_pin_group pinmux_groups[] = {
>  	SH_PFC_PIN_GROUP(eth_link),
> @@ -2945,6 +2963,8 @@ static const struct sh_pfc_pin_group pin
>  	SH_PFC_PIN_GROUP(sdhi2_ctrl),
>  	SH_PFC_PIN_GROUP(sdhi2_cd),
>  	SH_PFC_PIN_GROUP(sdhi2_wp),
> +	SH_PFC_PIN_GROUP(usb0),
> +	SH_PFC_PIN_GROUP(usb1),
>  };
> 
>  static const char * const eth_groups[] = {
> @@ -3219,6 +3239,14 @@ static const char * const sdhi2_groups[]
>  	"sdhi2_wp",
>  };
> 
> +static const char * const usb0_groups[] = {
> +	"usb0",
> +};
> +
> +static const char * const usb1_groups[] = {
> +	"usb1",
> +};
> +
>  static const struct sh_pfc_function pinmux_functions[] = {
>  	SH_PFC_FUNCTION(eth),
>  	SH_PFC_FUNCTION(hscif0),
> @@ -3253,6 +3281,8 @@ static const struct sh_pfc_function pinm
>  	SH_PFC_FUNCTION(sdhi0),
>  	SH_PFC_FUNCTION(sdhi1),
>  	SH_PFC_FUNCTION(sdhi2),
> +	SH_PFC_FUNCTION(usb0),
> +	SH_PFC_FUNCTION(usb1),
>  };
> 
>  static const struct pinmux_cfg_reg pinmux_config_regs[] = {
Sergei Shtylyov Aug. 20, 2015, 12:59 p.m. UTC | #2
Hello.

On 8/20/2015 12:14 AM, Laurent Pinchart wrote:

> Thank you for the patch.

    My pleasure. :-)

> On Wednesday 19 August 2015 01:26:55 Sergei Shtylyov wrote:
>> From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
>>
>> Add USB0/1 pin groups to R8A7794 PFC driver.
>>
>> Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
>> [Sergei: rebased, renamed, added changelog.]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    Thank you!
    How about the VIN patch? :-)

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Aug. 20, 2015, 7:44 p.m. UTC | #3
Hi Sergei,

On Thursday 20 August 2015 15:59:46 Sergei Shtylyov wrote:
> On 8/20/2015 12:14 AM, Laurent Pinchart wrote:
> > Thank you for the patch.
> 
> My pleasure. :-)
> 
> > On Wednesday 19 August 2015 01:26:55 Sergei Shtylyov wrote:
> >> From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> >> 
> >> Add USB0/1 pin groups to R8A7794 PFC driver.
> >> 
> >> Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> >> [Sergei: rebased, renamed, added changelog.]
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Thank you!
> How about the VIN patch? :-)

I was hoping someone else would review that one :-) Geert, would you have a 
bit of bandwidth to spare ?
Sergei Shtylyov Aug. 20, 2015, 7:48 p.m. UTC | #4
On 08/20/2015 10:44 PM, Laurent Pinchart wrote:

>>> Thank you for the patch.
>>
>> My pleasure. :-)
>>
>>> On Wednesday 19 August 2015 01:26:55 Sergei Shtylyov wrote:
>>>> From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
>>>>
>>>> Add USB0/1 pin groups to R8A7794 PFC driver.
>>>>
>>>> Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
>>>> [Sergei: rebased, renamed, added changelog.]
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>
>> Thank you!
>> How about the VIN patch? :-)
>
> I was hoping someone else would review that one :-)  Geert, would you have a
> bit of bandwidth to spare ?

   The MAINTAINERS file still has you as the Renesas PFC maintainer not Geert. ;-)

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Aug. 26, 2015, 11:41 a.m. UTC | #5
On Wed, Aug 19, 2015 at 12:26 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:

> From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
>
> Add USB0/1 pin groups to R8A7794 PFC driver.
>
> Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> [Sergei: rebased, renamed, added changelog.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Patch applied with Laurent's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
===================================================================
--- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
+++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
@@ -2770,6 +2770,24 @@  static const unsigned int sdhi2_wp_pins[
 static const unsigned int sdhi2_wp_mux[] = {
 	SD2_WP_MARK,
 };
+/* - USB0 ------------------------------------------------------------------- */
+static const unsigned int usb0_pins[] = {
+	RCAR_GP_PIN(5, 24), /* PWEN */
+	RCAR_GP_PIN(5, 25), /* OVC */
+};
+static const unsigned int usb0_mux[] = {
+	USB0_PWEN_MARK,
+	USB0_OVC_MARK,
+};
+/* - USB1 ------------------------------------------------------------------- */
+static const unsigned int usb1_pins[] = {
+	RCAR_GP_PIN(5, 26), /* PWEN */
+	RCAR_GP_PIN(5, 27), /* OVC */
+};
+static const unsigned int usb1_mux[] = {
+	USB1_PWEN_MARK,
+	USB1_OVC_MARK,
+};
 
 static const struct sh_pfc_pin_group pinmux_groups[] = {
 	SH_PFC_PIN_GROUP(eth_link),
@@ -2945,6 +2963,8 @@  static const struct sh_pfc_pin_group pin
 	SH_PFC_PIN_GROUP(sdhi2_ctrl),
 	SH_PFC_PIN_GROUP(sdhi2_cd),
 	SH_PFC_PIN_GROUP(sdhi2_wp),
+	SH_PFC_PIN_GROUP(usb0),
+	SH_PFC_PIN_GROUP(usb1),
 };
 
 static const char * const eth_groups[] = {
@@ -3219,6 +3239,14 @@  static const char * const sdhi2_groups[]
 	"sdhi2_wp",
 };
 
+static const char * const usb0_groups[] = {
+	"usb0",
+};
+
+static const char * const usb1_groups[] = {
+	"usb1",
+};
+
 static const struct sh_pfc_function pinmux_functions[] = {
 	SH_PFC_FUNCTION(eth),
 	SH_PFC_FUNCTION(hscif0),
@@ -3253,6 +3281,8 @@  static const struct sh_pfc_function pinm
 	SH_PFC_FUNCTION(sdhi0),
 	SH_PFC_FUNCTION(sdhi1),
 	SH_PFC_FUNCTION(sdhi2),
+	SH_PFC_FUNCTION(usb0),
+	SH_PFC_FUNCTION(usb1),
 };
 
 static const struct pinmux_cfg_reg pinmux_config_regs[] = {