diff mbox

[net-next] r8169:Set RxConfig on same func. with TxConfig

Message ID 1439925021-5772-1-git-send-email-corcodel.marian@gmail.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Corcodel Marian Aug. 18, 2015, 7:10 p.m. UTC 
Add set DMA burst size and  Rx FIFO threshold on RxConfig  
  register to function rtl_set_rx_tx_config_register.


Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>

Comments

David Miller Aug. 18, 2015, 7:42 p.m. UTC | #1 
From: Corcodel Marian <corcodel.marian@gmail.com>
Date: Tue, 18 Aug 2015 22:10:21 +0300

>  Add set DMA burst size and  Rx FIFO threshold on RxConfig  
>   register to function rtl_set_rx_tx_config_register.
> 
> 
> Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>

I would like to politely ask you to stop submitting these r8169 patches
right now.

Your method of handling your patch submissions is not acceptable and
is scarily wasting developer resources every single day.

When people give you feedback about why your patch is not correct, or
ask you questions, you often do not respond.  Or, if you do respond,
you give a very small response that do not actually answer the
question given to you.

When people give feedback to your patch, you _MUST_ engage in a
coherent full conversation with the person giving you feedback.

It is not acceptable to just ignore what that person tells you,
or to be quiet.  You cannot just keep throwing patches blindly
to this mailing list.

It is especially not acceptable to ignore feedback, and then keep
submitting more and more patches.  This is the worst thing in the
world that you can do.

You are creating a situation where the people trying to help you by
reviewing your work feel like they are wasting their time.

Furthermore, you haven't answered the most basic question we have
asked you.  Where are all of these r1869 patches coming from?  What is
the reason why you are looking into all of the r8169 issues all of a
sudden?  It looks very random and strange to all of us.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Dumazet Aug. 18, 2015, 8:04 p.m. UTC | #2 
On Tue, 2015-08-18 at 22:10 +0300, Corcodel Marian wrote:
>  Add set DMA burst size and  Rx FIFO threshold on RxConfig  
>   register to function rtl_set_rx_tx_config_register.
> 
> 
> Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 6d16de3..c3c908c 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -5183,6 +5183,7 @@ static void rtl_set_rx_tx_config_registers(struct rtl8169_private *tp)
>  	/* Set DMA burst size and Interframe Gap Time */
>  	RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
>                  (InterFrameGap << TxInterFrameGapShift) | InterFrameGap2);
> +	RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
>  }
>  
>  static void rtl_hw_start(struct net_device *dev)

This does not even compile. This is insane.



  CC [M]  drivers/net/ethernet/realtek/r8169.o
drivers/net/ethernet/realtek/r8169.c: In function
‘rtl_set_rx_tx_config_registers’:
drivers/net/ethernet/realtek/r8169.c:5186:20: error: ‘RX_FIFO_THRESHOLD’
undeclared (first use in this function)
  RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
                    ^
drivers/net/ethernet/realtek/r8169.c:104:38: note: in definition of
macro ‘RTL_W32’
 #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
                                      ^
drivers/net/ethernet/realtek/r8169.c:5186:20: note: each undeclared
identifier is reported only once for each function it appears in
  RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
                    ^
drivers/net/ethernet/realtek/r8169.c:104:38: note: in definition of
macro ‘RTL_W32’
 #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
                                      ^
make[1]: *** [drivers/net/ethernet/realtek/r8169.o] Error 1
make: *** [drivers/net/ethernet/realtek/r8169.o] Error 2


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Corcodel Marian Aug. 19, 2015, 5:39 a.m. UTC | #3 
It s not mandatory to accept
these patches, if you wish
to apply good if you not ,not problem.

2015-08-18 23:04 GMT+03:00, Eric Dumazet <eric.dumazet@gmail.com>:
> On Tue, 2015-08-18 at 22:10 +0300, Corcodel Marian wrote:
>>  Add set DMA burst size and  Rx FIFO threshold on RxConfig
>>   register to function rtl_set_rx_tx_config_register.
>>
>>
>> Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169.c
>> b/drivers/net/ethernet/realtek/r8169.c
>> index 6d16de3..c3c908c 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -5183,6 +5183,7 @@ static void rtl_set_rx_tx_config_registers(struct
>> rtl8169_private *tp)
>>  	/* Set DMA burst size and Interframe Gap Time */
>>  	RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
>>                  (InterFrameGap << TxInterFrameGapShift) |
>> InterFrameGap2);
>> +	RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
>>  }
>>
>>  static void rtl_hw_start(struct net_device *dev)
>
> This does not even compile. This is insane.
>
>
>
>   CC [M]  drivers/net/ethernet/realtek/r8169.o
> drivers/net/ethernet/realtek/r8169.c: In function
> ‘rtl_set_rx_tx_config_registers’:
> drivers/net/ethernet/realtek/r8169.c:5186:20: error: ‘RX_FIFO_THRESHOLD’
> undeclared (first use in this function)
>   RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
>                     ^
> drivers/net/ethernet/realtek/r8169.c:104:38: note: in definition of
> macro ‘RTL_W32’
>  #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
>                                       ^
> drivers/net/ethernet/realtek/r8169.c:5186:20: note: each undeclared
> identifier is reported only once for each function it appears in
>   RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
>                     ^
> drivers/net/ethernet/realtek/r8169.c:104:38: note: in definition of
> macro ‘RTL_W32’
>  #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
>                                       ^
> make[1]: *** [drivers/net/ethernet/realtek/r8169.o] Error 1
> make: *** [drivers/net/ethernet/realtek/r8169.o] Error 2
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Dumazet Aug. 19, 2015, 1:34 p.m. UTC | #4 
On Wed, 2015-08-19 at 08:39 +0300, Marian Corcodel wrote:
> It s not mandatory to accept
> these patches, if you wish
> to apply good if you not ,not problem.

How can we apply a patch that does not compile ?

You are going to piss all netdev people for good.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 6d16de3..c3c908c 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -5183,6 +5183,7 @@  static void rtl_set_rx_tx_config_registers(struct rtl8169_private *tp)
 	/* Set DMA burst size and Interframe Gap Time */
 	RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
                 (InterFrameGap << TxInterFrameGapShift) | InterFrameGap2);
+	RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
 }
 
 static void rtl_hw_start(struct net_device *dev)