diff mbox

[15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE

Message ID 1439886649-24166-16-git-send-email-phil@nwl.cc
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Phil Sutter Aug. 18, 2015, 8:30 a.m. UTC
Signed-off-by: Phil Sutter <phil@nwl.cc>
Cc: Johannes Berg <johannes@sipsolutions.net>
---
 drivers/net/wireless/mac80211_hwsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Berg Aug. 18, 2015, 8:43 a.m. UTC | #1
On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote:
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> ---
>  drivers/net/wireless/mac80211_hwsim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mac80211_hwsim.c 
> b/drivers/net/wireless/mac80211_hwsim.c
> index 99e873d..a1dbcb2 100644
> --- a/drivers/net/wireless/mac80211_hwsim.c
> +++ b/drivers/net/wireless/mac80211_hwsim.c
> @@ -2676,7 +2676,7 @@ static void hwsim_mon_setup(struct net_device 
> *dev)
>  	dev->netdev_ops = &hwsim_netdev_ops;
>  	dev->destructor = free_netdev;
>  	ether_setup(dev);
> -	dev->tx_queue_len = 0;
> +	dev->priv_flags |= IFF_NO_QUEUE;
> 
Fine with me; Dave, are you going to pick up the entire series
(presumably there was one, I only got this patch)?

Note that there's no TX possible on this particular netdev anyway.

johannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Aug. 18, 2015, 6:54 p.m. UTC | #2
From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 18 Aug 2015 10:43:55 +0200

> On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote:
>> Signed-off-by: Phil Sutter <phil@nwl.cc>
>> Cc: Johannes Berg <johannes@sipsolutions.net>
>> ---
>>  drivers/net/wireless/mac80211_hwsim.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/wireless/mac80211_hwsim.c 
>> b/drivers/net/wireless/mac80211_hwsim.c
>> index 99e873d..a1dbcb2 100644
>> --- a/drivers/net/wireless/mac80211_hwsim.c
>> +++ b/drivers/net/wireless/mac80211_hwsim.c
>> @@ -2676,7 +2676,7 @@ static void hwsim_mon_setup(struct net_device 
>> *dev)
>>  	dev->netdev_ops = &hwsim_netdev_ops;
>>  	dev->destructor = free_netdev;
>>  	ether_setup(dev);
>> -	dev->tx_queue_len = 0;
>> +	dev->priv_flags |= IFF_NO_QUEUE;
>> 
> Fine with me; Dave, are you going to pick up the entire series
> (presumably there was one, I only got this patch)?
> 
> Note that there's no TX possible on this particular netdev anyway.

Yes, I'm going to take the full series.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 99e873d..a1dbcb2 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -2676,7 +2676,7 @@  static void hwsim_mon_setup(struct net_device *dev)
 	dev->netdev_ops = &hwsim_netdev_ops;
 	dev->destructor = free_netdev;
 	ether_setup(dev);
-	dev->tx_queue_len = 0;
+	dev->priv_flags |= IFF_NO_QUEUE;
 	dev->type = ARPHRD_IEEE80211_RADIOTAP;
 	eth_zero_addr(dev->dev_addr);
 	dev->dev_addr[0] = 0x12;