diff mbox

[1/1] UBUNTU: [Config] enforce -- ensure dm_mod is built-in for LVM

Message ID 1272030866-15373-1-git-send-email-apw@canonical.com
State Accepted
Delegated to: Andy Whitcroft
Headers show

Commit Message

Andy Whitcroft April 23, 2010, 1:54 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/560717

We much build-in dm-mod otherwise LVM cannot activate on boot,
ensure this is so.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
 debian/config/enforce |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Comments

Stefan Bader April 23, 2010, 2:22 p.m. UTC | #1
Andy Whitcroft wrote:
> BugLink: http://bugs.launchpad.net/bugs/560717
> 
> We much build-in dm-mod otherwise LVM cannot activate on boot,
> ensure this is so.

Patch looks ok. Description does not parse for me. How about

We need to make dm-mod a built-in...

For patch itself
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian/config/enforce |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/debian/config/enforce b/debian/config/enforce
> index f879680..8180e94 100644
> --- a/debian/config/enforce
> +++ b/debian/config/enforce
> @@ -32,3 +32,6 @@ value CONFIG_DEVTMPFS_MOUNT y
>  
>  # Ramdisk size should be a minimum of 64M
>  value CONFIG_BLK_DEV_RAM_SIZE 65536
> +
> +# LVM requires dm_mod built in to activate correctly (LP: #560717)
> +value CONFIG_BLK_DEV_DM y
Andy Whitcroft April 23, 2010, 3:14 p.m. UTC | #2
On Fri, Apr 23, 2010 at 04:22:02PM +0200, Stefan Bader wrote:
> Andy Whitcroft wrote:
> > BugLink: http://bugs.launchpad.net/bugs/560717
> > 
> > We much build-in dm-mod otherwise LVM cannot activate on boot,
> > ensure this is so.

We must build-in ...

> 
> Patch looks ok. Description does not parse for me. How about
> 
> We need to make dm-mod a built-in...
> 
> For patch itself
> > Signed-off-by: Andy Whitcroft <apw@canonical.com>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
> > ---
> >  debian/config/enforce |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/debian/config/enforce b/debian/config/enforce
> > index f879680..8180e94 100644
> > --- a/debian/config/enforce
> > +++ b/debian/config/enforce
> > @@ -32,3 +32,6 @@ value CONFIG_DEVTMPFS_MOUNT y
> >  
> >  # Ramdisk size should be a minimum of 64M
> >  value CONFIG_BLK_DEV_RAM_SIZE 65536
> > +
> > +# LVM requires dm_mod built in to activate correctly (LP: #560717)
> > +value CONFIG_BLK_DEV_DM y
>
Tim Gardner April 23, 2010, 3:17 p.m. UTC | #3
On 04/23/2010 07:54 AM, Andy Whitcroft wrote:
> BugLink: http://bugs.launchpad.net/bugs/560717
>
> We much build-in dm-mod otherwise LVM cannot activate on boot,
> ensure this is so.
>
> Signed-off-by: Andy Whitcroft<apw@canonical.com>
> ---
>   debian/config/enforce |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/debian/config/enforce b/debian/config/enforce
> index f879680..8180e94 100644
> --- a/debian/config/enforce
> +++ b/debian/config/enforce
> @@ -32,3 +32,6 @@ value CONFIG_DEVTMPFS_MOUNT y
>
>   # Ramdisk size should be a minimum of 64M
>   value CONFIG_BLK_DEV_RAM_SIZE 65536
> +
> +# LVM requires dm_mod built in to activate correctly (LP: #560717)
> +value CONFIG_BLK_DEV_DM y

Mangled commit log comment notwithstanding.

Acked-by: Tim Gardner <tim.gardner@canonical.com>
Andy Whitcroft April 23, 2010, 3:52 p.m. UTC | #4
Description converted to english and ...

Applied to Lucid.

-apw
diff mbox

Patch

diff --git a/debian/config/enforce b/debian/config/enforce
index f879680..8180e94 100644
--- a/debian/config/enforce
+++ b/debian/config/enforce
@@ -32,3 +32,6 @@  value CONFIG_DEVTMPFS_MOUNT y
 
 # Ramdisk size should be a minimum of 64M
 value CONFIG_BLK_DEV_RAM_SIZE 65536
+
+# LVM requires dm_mod built in to activate correctly (LP: #560717)
+value CONFIG_BLK_DEV_DM y