| Message ID | 20100423133347.27001.99171.stgit@shiryu.yomgui.biz |
|---|---|
| State | New, archived |
| Headers | show |
Le 23/04/2010 15:33, Guillaume LECERF a écrit : > From: Uwe Kleine-König<Uwe.Kleine-Koenigi@digi.com> > > After the deleted block bootloc is only used once as follows: > > if (bootloc == 3&& something_else) { > ... > > So setting bootloc = 2 doesn't change anything. Taking that the warning is > wrong and missleading. > > Signed-off-by: Uwe Kleine-König<Uwe.Kleine-Koenig@digi.com> > --- > drivers/mtd/chips/cfi_cmdset_0002.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c > index ea2a7f6..8da8655 100644 > --- a/drivers/mtd/chips/cfi_cmdset_0002.c > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c > @@ -391,11 +391,6 @@ struct mtd_info *cfi_cmdset_0002(struct map_info *map, int primary) > #endif > > bootloc = extp->TopBottom; > - if ((bootloc != 2)&& (bootloc != 3)) { > - printk(KERN_WARNING "%s: CFI does not contain boot " > - "bank location. Assuming top.\n", map->name); > - bootloc = 2; > - } > > if (bootloc == 3&& cfi->cfiq->NumEraseRegions> 1) { > printk(KERN_WARNING "%s: Swapping erase regions for broken CFI table.\n", map->name); > > FWIW:- Acked-by Christopher Moore <moore@free.fr>
On Fri, Apr 23, 2010 at 03:33:47PM +0200, Guillaume LECERF wrote: > From: Uwe Kleine-König <Uwe.Kleine-Koenigi@digi.com> > > After the deleted block bootloc is only used once as follows: > > if (bootloc == 3 && something_else) { > ... > > So setting bootloc = 2 doesn't change anything. Taking that the warning is > wrong and missleading. > > Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com> I think you need to sign it off as well (as you are sending it upstream). And although I am not the one picking the patches up, I could imagine it helps David if you respin the whole patch-series with all the latest updates and adding all the Acked-by and Reviewed-by tags you got. This should speed things up and help merging. Regards, Wolfram
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index ea2a7f6..8da8655 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -391,11 +391,6 @@ struct mtd_info *cfi_cmdset_0002(struct map_info *map, int primary) #endif bootloc = extp->TopBottom; - if ((bootloc != 2) && (bootloc != 3)) { - printk(KERN_WARNING "%s: CFI does not contain boot " - "bank location. Assuming top.\n", map->name); - bootloc = 2; - } if (bootloc == 3 && cfi->cfiq->NumEraseRegions > 1) { printk(KERN_WARNING "%s: Swapping erase regions for broken CFI table.\n", map->name);