Patchwork nfs41: potential null deref in xprt_reserve_xprt()?

mail settings
Submitter Dan Carpenter
Date April 23, 2010, noon
Message ID <20100423120013.GF29093@bicker>
Download mbox | patch
Permalink /patch/50811/
State Not Applicable
Delegated to: David Miller
Headers show


Dan Carpenter - April 23, 2010, noon
I'm going through some Smatch results and had a question.  

Until commit 343952fa5a: "nfs41: Get the rpc_xprt * from the rpc_rqst 
instead of the rpc_clnt." we assumed that "task->tk_rqstp" can be NULL.  
But that patch dereferences it unconditionally.

isn't null very often.

If you would like, I can remove the checks for null from the rest of the

dan carpenter
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at


diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
index 0eea2bf..c144611 100644
--- a/net/sunrpc/xprt.c
+++ b/net/sunrpc/xprt.c
@@ -195,8 +195,8 @@  EXPORT_SYMBOL_GPL(xprt_load_transport);
 int xprt_reserve_xprt(struct rpc_task *task)
-       struct rpc_xprt *xprt = task->tk_xprt;
        struct rpc_rqst *req = task->tk_rqstp;
+       struct rpc_xprt *xprt = req->rq_xprt;

Can "req" be null here?  The patch is a year old, so presumably it