From patchwork Fri Apr 23 08:53:16 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Spencer Oliver X-Patchwork-Id: 50800 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 54877B7D1D for ; Fri, 23 Apr 2010 19:03:05 +1000 (EST) Received: from localhost ([127.0.0.1]:57726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5Eev-0003vH-F9 for incoming@patchwork.ozlabs.org; Fri, 23 Apr 2010 04:54:49 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O5EdX-0003uM-VJ for qemu-devel@nongnu.org; Fri, 23 Apr 2010 04:53:24 -0400 Received: from [140.186.70.92] (port=54339 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5EdW-0003so-FN for qemu-devel@nongnu.org; Fri, 23 Apr 2010 04:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O5EdU-0003d5-T9 for qemu-devel@nongnu.org; Fri, 23 Apr 2010 04:53:22 -0400 Received: from relay.pcl-ipout02.plus.net ([212.159.7.100]:53937) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O5EdU-0003ce-PG for qemu-devel@nongnu.org; Fri, 23 Apr 2010 04:53:20 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: As0FAI/80EvUnwpB/2dsb2JhbACQKoxyvgeFDwQ Received: from mailc01.plus.net (HELO pih-smtp-proxy01.plus.net) ([212.159.10.65]) by relay.pcl-ipout02.plus.net with ESMTP; 23 Apr 2010 09:53:17 +0100 Received: from [80.189.249.164] (helo=[192.168.0.2]) by pih-smtp-proxy01.plus.net with esmtp (Exim 4.63) (envelope-from ) id 1O5EdR-0000VD-Ay for qemu-devel@nongnu.org; Fri, 23 Apr 2010 09:53:17 +0100 Received: from 127.0.0.1 (AVG SMTP 9.0.801 [271.1.1/2830]); Fri, 23 Apr 2010 09:53:16 +0100 Message-ID: <4BD15FFC.5030800@spen-soft.co.uk> Date: Fri, 23 Apr 2010 09:53:16 +0100 From: Spencer Oliver User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.9) Gecko/20100317 Lightning/1.0b1 Thunderbird/3.0.4 MIME-Version: 1.0 To: qemu-devel@nongnu.org X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Subject: [Qemu-devel] [PATCH] usb-wacom: fix usb_wacom_initfn regression X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From 2c0a39852848d146e27843ab3b45ff8cdf49ba86 Mon Sep 17 00:00:00 2001 From: Spencer Oliver Date: Fri, 23 Apr 2010 09:07:23 +0100 Subject: [PATCH] usb-wacom: fix usb_wacom_initfn regression eh_entry was not intialized and so produced a seg fault when WACOM_SET_REPORT was called. --- hw/usb-wacom.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb-wacom.c b/hw/usb-wacom.c index fe052eb..49766ac 100644 --- a/hw/usb-wacom.c +++ b/hw/usb-wacom.c @@ -404,6 +404,9 @@ static int usb_wacom_initfn(USBDevice *dev) { USBWacomState *s = DO_UPCAST(USBWacomState, dev, dev); s->dev.speed = USB_SPEED_FULL; + s->eh_entry = qemu_add_mouse_event_handler(usb_mouse_event, s, 0, + "QEMU PenPartner tablet"); + /* Force poll routine to be run and grab input the first time. */ s->changed = 1; return 0; }