| Message ID | 1439781546-7217-5-git-send-email-jiang.liu@linux.intel.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Aug 16, 2015 at 8:19 PM, Jiang Liu <jiang.liu@linux.intel.com> wrote: > Function ovs_flow_stats_update() allocates memory with __GFP_THISNODE > flag set, which may cause permanent memory allocation failure on > memoryless node. So replace cpu_to_node() with cpu_to_mem() to better > support memoryless node. For node with memory, cpu_to_mem() is the same > as cpu_to_node(). > > This change only affects performance and shouldn't affect functionality. > > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> Acked-by: Pravin B Shelar <pshelar@nicira.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c index bc7b0aba994a..e50a5681d0c2 100644 --- a/net/openvswitch/flow.c +++ b/net/openvswitch/flow.c @@ -69,7 +69,7 @@ void ovs_flow_stats_update(struct sw_flow *flow, __be16 tcp_flags, const struct sk_buff *skb) { struct flow_stats *stats; - int node = numa_node_id(); + int node = numa_mem_id(); int len = skb->len + (skb_vlan_tag_present(skb) ? VLAN_HLEN : 0); stats = rcu_dereference(flow->stats[node]);
Function ovs_flow_stats_update() allocates memory with __GFP_THISNODE flag set, which may cause permanent memory allocation failure on memoryless node. So replace cpu_to_node() with cpu_to_mem() to better support memoryless node. For node with memory, cpu_to_mem() is the same as cpu_to_node(). This change only affects performance and shouldn't affect functionality. Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> --- net/openvswitch/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)