Patchworkβ powerpc/spufs: explain conditional decrement of aff_sched_count

login
register
about
Submitter Andre Detsch
Date 2008-10-20 15:27:07
Message ID <200810201327.07179.adetsch@br.ibm.com>
Download mbox | patch
Permalink /patch/5075/
State Accepted
Headers show

Comments

Andre Detsch - 2008-10-20 15:27:07
This patch adds a comment to clarify why atomic_dec_if_positive is being used
to decrement gang's aff_sched_count on SPU context unbind.

Signed-off-by: Andre Detsch <adetsch@br.ibm.com>

Patch

Index: spufs/arch/powerpc/platforms/cell/spufs/sched.c
===================================================================
--- spufs.orig/arch/powerpc/platforms/cell/spufs/sched.c
+++ spufs/arch/powerpc/platforms/cell/spufs/sched.c
@@ -437,6 +437,11 @@  static void spu_unbind_context(struct sp
 		atomic_dec(&cbe_spu_info[spu->node].reserved_spus);

 	if (ctx->gang)
+		/*
+		 * If ctx->gang->aff_sched_count is positive, SPU affinity is
+		 * being considered in this gang. Using atomic_dec_if_positive
+		 * allow us to skip an explicit check for affinity in this gang
+		 */
 		atomic_dec_if_positive(&ctx->gang->aff_sched_count);

 	spu_switch_notify(spu, NULL);