diff mbox

[v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module

Message ID 1439531649-46827-1-git-send-email-dongsheng.wang@freescale.com (mailing list archive)
State Awaiting Upstream, archived
Headers show

Commit Message

Dongsheng Wang Aug. 14, 2015, 5:54 a.m. UTC 
From: Jason Jin <Jason.Jin@freescale.com>

For deep sleep, the diu module will power off, when wake up
from the deep sleep, the registers need to be reinitialized.

Signed-off-by: Jason Jin <Jason.Jin@freescale.com>
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
---
*v2*
Changes:
- int i -> unsigned int i.

Rmove:
- struct mfb_info *mfbi;

Comments

Timur Tabi Aug. 15, 2015, 3:45 a.m. UTC | #1 
Dongsheng Wang wrote:
> For deep sleep, the diu module will power off, when wake up
> from the deep sleep, the registers need to be reinitialized.
>
> Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
> Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>

Acked-by: Timur Tabi <timur@tabi.org>
Dongsheng Wang Aug. 17, 2015, 6:05 a.m. UTC | #2 
Thanks Timur.

@Scott,
Could you apply this patch?

Regards,
-Dongsheng

> -----Original Message-----
> From: Timur Tabi [mailto:timur@tabi.org]
> Sent: Saturday, August 15, 2015 11:45 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; Jin Zhengxiong-R64188; linuxppc-dev@lists.ozlabs.org;
> linux-fbdev@vger.kernel.org
> Subject: Re: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU
> module
> 
> Dongsheng Wang wrote:
> > For deep sleep, the diu module will power off, when wake up from the
> > deep sleep, the registers need to be reinitialized.
> >
> > Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
> > Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>
> 
> Acked-by: Timur Tabi <timur@tabi.org>
Timur Tabi Aug. 17, 2015, 12:31 p.m. UTC | #3 
Wang Dongsheng wrote:
> Thanks Timur.
>
> @Scott,
> Could you apply this patch?

You need to ask the fbdev maintainer to apply it, because it has to go 
through his tree.
Dongsheng Wang Sept. 24, 2015, 10:02 a.m. UTC | #4 
Hi Tomi,

Could you apply this patch?

> > For deep sleep, the diu module will power off, when wake up from the
> > deep sleep, the registers need to be reinitialized.
> >
> > Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
> > Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>
> 
> Acked-by: Timur Tabi <timur@tabi.org>

Regards,
-Dongsheng
Tomi Valkeinen Sept. 24, 2015, 10:07 a.m. UTC | #5 
On 24/09/15 13:02, Wang Dongsheng wrote:
> Hi Tomi,
> 
> Could you apply this patch?
> 
>>> For deep sleep, the diu module will power off, when wake up from the
>>> deep sleep, the registers need to be reinitialized.
>>>
>>> Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
>>> Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>
>>
>> Acked-by: Timur Tabi <timur@tabi.org>

Thanks, queued for 4.3 fixes.

 Tomi
diff mbox

Patch

diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 7fa2e6f..b335c1a 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1628,9 +1628,16 @@  static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
 static int fsl_diu_resume(struct platform_device *ofdev)
 {
 	struct fsl_diu_data *data;
+	unsigned int i;
 
 	data = dev_get_drvdata(&ofdev->dev);
-	enable_lcdc(data->fsl_diu_info);
+
+	fsl_diu_enable_interrupts(data);
+	update_lcdc(data->fsl_diu_info);
+	for (i = 0; i < NUM_AOIS; i++) {
+		if (data->mfb[i].count)
+			fsl_diu_enable_panel(&data->fsl_diu_info[i]);
+	}
 
 	return 0;
 }