diff mbox

[U-Boot,v3,8/9] dfu: tftp: Kconfig: Add Kconfig entry for dfu tftp feature

Message ID 1439506953-23090-9-git-send-email-l.majewski@majess.pl
State Superseded
Delegated to: Ɓukasz Majewski
Headers show

Commit Message

Lukasz Majewski Aug. 13, 2015, 11:02 p.m. UTC
The dfu tftp feature can be now enabled via Kconfig. This
commit provides necessary code for it.

Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
---
Changes for v3:
- New patch
---
 drivers/dfu/Kconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Joe Hershberger Aug. 18, 2015, 3:12 p.m. UTC | #1
Hi Lukasz,

On Thu, Aug 13, 2015 at 6:02 PM, Lukasz Majewski <l.majewski@majess.pl> wrote:
> The dfu tftp feature can be now enabled via Kconfig. This
> commit provides necessary code for it.
>
> Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> ---
> Changes for v3:
> - New patch
> ---
>  drivers/dfu/Kconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index e69de29..700c6a5 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -0,0 +1,10 @@
> +menu "DFU support"
> +
> +config DFU_TFTP
> +       bool "Enable support for performing Device Firmware Upgrade via TFTP"

This is a pretty verbose bool text. The help is there for
clarification and wordiness. Maybe something like "DFU via TFTP".

> +       help
> +         This option allows performing update of DFU managed medium with data
> +         send via TFTP boot.
> +         Detailed description of this feature can be found at ./doc/README.dfutftp
> +
> +endmenu
Lukasz Majewski Aug. 18, 2015, 9:19 p.m. UTC | #2
On Tue, 18 Aug 2015 10:12:40 -0500
Joe Hershberger <joe.hershberger@gmail.com> wrote:

> Hi Lukasz,
> 
> On Thu, Aug 13, 2015 at 6:02 PM, Lukasz Majewski
> <l.majewski@majess.pl> wrote:
> > The dfu tftp feature can be now enabled via Kconfig. This
> > commit provides necessary code for it.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> > ---
> > Changes for v3:
> > - New patch
> > ---
> >  drivers/dfu/Kconfig | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> > index e69de29..700c6a5 100644
> > --- a/drivers/dfu/Kconfig
> > +++ b/drivers/dfu/Kconfig
> > @@ -0,0 +1,10 @@
> > +menu "DFU support"
> > +
> > +config DFU_TFTP
> > +       bool "Enable support for performing Device Firmware Upgrade
> > via TFTP"
> 
> This is a pretty verbose bool text. The help is there for
> clarification and wordiness. Maybe something like "DFU via TFTP".

Good point. I will change this.
> 
> > +       help
> > +         This option allows performing update of DFU managed
> > medium with data
> > +         send via TFTP boot.
> > +         Detailed description of this feature can be found
> > at ./doc/README.dfutftp +
> > +endmenu

Best regards,
Lukasz Majewski
diff mbox

Patch

diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
index e69de29..700c6a5 100644
--- a/drivers/dfu/Kconfig
+++ b/drivers/dfu/Kconfig
@@ -0,0 +1,10 @@ 
+menu "DFU support"
+
+config DFU_TFTP
+	bool "Enable support for performing Device Firmware Upgrade via TFTP"
+	help
+	  This option allows performing update of DFU managed medium with data
+	  send via TFTP boot.
+	  Detailed description of this feature can be found at ./doc/README.dfutftp
+
+endmenu