From patchwork Mon Oct 20 12:13:15 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "jonsmirl@gmail.com" X-Patchwork-Id: 5067 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 8DDE3DDF19 for ; Mon, 20 Oct 2008 23:13:37 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.236]) by ozlabs.org (Postfix) with ESMTP id BE4EFDDDEA for ; Mon, 20 Oct 2008 23:13:20 +1100 (EST) Received: by wx-out-0506.google.com with SMTP id s6so1184135wxc.15 for ; Mon, 20 Oct 2008 05:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:subject:to:date :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=UCUsX3XIFTJzkDva1I5BXblK4BtNdI4DrMhyaALRyl0=; b=KUHrO/uMX9Sasy0MJwFnff+bdv5sMKsDyDLDOPkIq86dtc26BNFzhh4+Lv8lK1KUKs U+8Lp0tBgzGXArRsZGXyMf94t9qQCC+o8yZCdKz5g/Cv7w4x78Nlr3nDM1mUpE/Igr+2 Zha8U3E6OgAvkmmRaEbDeyT2MUzMXFEBmARPo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:subject:to:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; b=tkznCNt3zNX6xR/zS/cvmLka3/5Au+Ecq+ontUjeOlmdpKy8EWFk4Kb/UTy/UMsosJ mtEEFg/E3AgaIJjH//1COmOV3TpcIpAXf45nNQxSMXPkFd21l+CwbIDo3Hf6i6DmgtjB j3rwu28MQ/dF+KsUReN8Z1ygN+CE0eDoFXY8w= Received: by 10.70.33.8 with SMTP id g8mr8594995wxg.23.1224504798691; Mon, 20 Oct 2008 05:13:18 -0700 (PDT) Received: from terra (c-76-109-159-38.hsd1.fl.comcast.net [76.109.159.38]) by mx.google.com with ESMTPS id 38sm8065098wrl.1.2008.10.20.05.13.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 20 Oct 2008 05:13:18 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=[127.0.1.1]) by terra with esmtp (Exim 4.69) (envelope-from ) id 1KrtdL-0002ig-GI for linuxppc-dev@ozlabs.org; Mon, 20 Oct 2008 08:13:15 -0400 From: Jon Smirl Subject: [PATCH] Format string bug in drivers/of/of_i2c.c To: linuxppc-dev@ozlabs.org Date: Mon, 20 Oct 2008 08:13:15 -0400 Message-ID: <20081020121315.10428.10730.stgit@terra> User-Agent: StGIT/0.14.3.224.g199b MIME-Version: 1.0 X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Format string bug. Not exploitable, as this is only writable by root, but worth fixing all the same. See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b --- drivers/of/of_i2c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c index 6a98dc8..24bbef7 100644 --- a/drivers/of/of_i2c.c +++ b/drivers/of/of_i2c.c @@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap, info.addr = *addr; - request_module(info.type); + request_module("%s", info.type); result = i2c_new_device(adap, &info); if (result == NULL) {