Patchwork [Lucid] Revert "UBUNTU: (pre-stable): input: ALPS - Add signature for HP Pavilion dm3 laptops"

login
register
mail settings
Submitter Chase Douglas
Date April 21, 2010, 2:05 p.m.
Message ID <1271858700-17392-1-git-send-email-chase.douglas@canonical.com>
Download mbox | patch
Permalink /patch/50658/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Chase Douglas - April 21, 2010, 2:05 p.m.
This reverts commit d7dc6bc007a098ff0f842549c054002611611f29.

SRU Justification:

Impact: The end result of the commit is loss of scroll support, with no
extra functionality gained.

How addressed: By reverting the commit, the previously enabled scroll
support is reestablished through the ImPS/2 extension.

Reproduction: Run current Ubuntu kernel on affected hardware. Scroll
functionality present in previous Ubuntu releases is now missing.

Regression Potential: Since this is a revert of a one-line device id,
the regression potential is minimal. The device should fall back to
ImPS/2 protocol without issue.

-----

The commit added a signature for new ALPS touchpads. Unfortunately, the
protocol for enabling absolute events appears to have changed for this
hardware. With this commit, only strict PS/2 events are provided by the
device, meaning only relative motion events.

By reverting this commit, the ImPS/2 protocol extension is used. The
extension allows the hardware to provide scroll wheel events itself.
This behavior is preferred until the proper protocol for this device is
determined.

The upstream linux-input tree has been reverted at this time, and the
patch has been NACK'd in the -stable queue.

BugLink: http://bugs.launchpad.net/bugs/550625

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/input/mouse/alps.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Andy Whitcroft - April 21, 2010, 2:24 p.m.
On Wed, Apr 21, 2010 at 10:05:00AM -0400, Chase Douglas wrote:
> This reverts commit d7dc6bc007a098ff0f842549c054002611611f29.
> 
> SRU Justification:
> 
> Impact: The end result of the commit is loss of scroll support, with no
> extra functionality gained.
> 
> How addressed: By reverting the commit, the previously enabled scroll
> support is reestablished through the ImPS/2 extension.
> 
> Reproduction: Run current Ubuntu kernel on affected hardware. Scroll
> functionality present in previous Ubuntu releases is now missing.
> 
> Regression Potential: Since this is a revert of a one-line device id,
> the regression potential is minimal. The device should fall back to
> ImPS/2 protocol without issue.
> 
> -----
> 
> The commit added a signature for new ALPS touchpads. Unfortunately, the
> protocol for enabling absolute events appears to have changed for this
> hardware. With this commit, only strict PS/2 events are provided by the
> device, meaning only relative motion events.
> 
> By reverting this commit, the ImPS/2 protocol extension is used. The
> extension allows the hardware to provide scroll wheel events itself.
> This behavior is preferred until the proper protocol for this device is
> determined.
> 
> The upstream linux-input tree has been reverted at this time, and the
> patch has been NACK'd in the -stable queue.
> 
> BugLink: http://bugs.launchpad.net/bugs/550625
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
>  drivers/input/mouse/alps.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index a0671bd..a9f461e 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -64,7 +64,6 @@ static const struct alps_model_info alps_model_data[] = {
>  	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },		  /* Dell Vostro 1400 */
>  	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
> -	{ { 0x73, 0x02, 0x64 }, 0xf8, 0xf8, 0 },			  /* HP Pavilion dm3 */
>  };
>  
>  /*

A new protocol huh ... nightmare h/w vendors.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Stefan Bader - April 21, 2010, 4:14 p.m.
This also has been dropped upstream stable now. Lets wait for when a real
solution comes up.

Chase Douglas wrote:
> This reverts commit d7dc6bc007a098ff0f842549c054002611611f29.
> 
> SRU Justification:
> 
> Impact: The end result of the commit is loss of scroll support, with no
> extra functionality gained.
> 
> How addressed: By reverting the commit, the previously enabled scroll
> support is reestablished through the ImPS/2 extension.
> 
> Reproduction: Run current Ubuntu kernel on affected hardware. Scroll
> functionality present in previous Ubuntu releases is now missing.
> 
> Regression Potential: Since this is a revert of a one-line device id,
> the regression potential is minimal. The device should fall back to
> ImPS/2 protocol without issue.
> 
> -----
> 
> The commit added a signature for new ALPS touchpads. Unfortunately, the
> protocol for enabling absolute events appears to have changed for this
> hardware. With this commit, only strict PS/2 events are provided by the
> device, meaning only relative motion events.
> 
> By reverting this commit, the ImPS/2 protocol extension is used. The
> extension allows the hardware to provide scroll wheel events itself.
> This behavior is preferred until the proper protocol for this device is
> determined.
> 
> The upstream linux-input tree has been reverted at this time, and the
> patch has been NACK'd in the -stable queue.
> 
> BugLink: http://bugs.launchpad.net/bugs/550625
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  drivers/input/mouse/alps.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index a0671bd..a9f461e 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -64,7 +64,6 @@ static const struct alps_model_info alps_model_data[] = {
>  	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },		  /* Dell Vostro 1400 */
>  	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
> -	{ { 0x73, 0x02, 0x64 }, 0xf8, 0xf8, 0 },			  /* HP Pavilion dm3 */
>  };
>  
>  /*
Andy Whitcroft - April 21, 2010, 4:38 p.m.
Chase, the Janitor will futz with the status of this bug when this
change goes in and you'll want to undo its meddling.

Applied to Lucid.

-apw

Patch

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index a0671bd..a9f461e 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -64,7 +64,6 @@  static const struct alps_model_info alps_model_data[] = {
 	{ { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },		  /* Dell Vostro 1400 */
 	{ { 0x52, 0x01, 0x14 }, 0xff, 0xff,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },	  /* Toshiba Tecra A11-11L */
-	{ { 0x73, 0x02, 0x64 }, 0xf8, 0xf8, 0 },			  /* HP Pavilion dm3 */
 };
 
 /*