diff mbox

[3/5] acpi: method: add _RST test

Message ID 1439284229-13839-3-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Aug. 11, 2015, 9:10 a.m. UTC
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Colin Ian King Aug. 17, 2015, 5:41 p.m. UTC | #1
On 11/08/15 02:10, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 7297b87..d5efb04 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -188,7 +188,7 @@
>   * _REV  5.7.4		n/a
>   * _RMV  6.3.6		Y
>   * _ROM  B.4.3		Y
> - * _RST  7.3.25		N
> + * _RST  7.3.25		Y
>   * _RTV  11.4.10	Y
>   * _S0_  7.3.4.1	Y
>   * _S1_  7.3.4.2	Y
> @@ -2892,6 +2892,12 @@ method_test_SxW(_S2W)
>  method_test_SxW(_S3W)
>  method_test_SxW(_S4W)
>  
> +static int method_test_RST(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_RST", NULL, 0, method_test_NULL_return, NULL);
> +}
> +
>  static int method_test_IRC(fwts_framework *fw)
>  {
>  	return method_evaluate_method(fw, METHOD_OPTIONAL,
> @@ -6376,6 +6382,7 @@ static fwts_framework_minor_test method_tests[] = {
>  	{ method_test_S2W, "Test _S2W (S2 Device Wake State)." },
>  	{ method_test_S3W, "Test _S3W (S3 Device Wake State)." },
>  	{ method_test_S4W, "Test _S4W (S4 Device Wake State)." },
> +	{ method_test_RST, "Test _RST (Device Reset)." },
>  
>  	/* Section 7.3 OEM-Supplied System-Level Control Methods */
>  	{ method_test_S0_, "Test _S0_ (S0 System State)." },
> 

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu Aug. 18, 2015, 3:25 a.m. UTC | #2
On 2015年08月11日 17:10, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/acpi/method/method.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 7297b87..d5efb04 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -188,7 +188,7 @@
>    * _REV  5.7.4		n/a
>    * _RMV  6.3.6		Y
>    * _ROM  B.4.3		Y
> - * _RST  7.3.25		N
> + * _RST  7.3.25		Y
>    * _RTV  11.4.10	Y
>    * _S0_  7.3.4.1	Y
>    * _S1_  7.3.4.2	Y
> @@ -2892,6 +2892,12 @@ method_test_SxW(_S2W)
>   method_test_SxW(_S3W)
>   method_test_SxW(_S4W)
>   
> +static int method_test_RST(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_RST", NULL, 0, method_test_NULL_return, NULL);
> +}
> +
>   static int method_test_IRC(fwts_framework *fw)
>   {
>   	return method_evaluate_method(fw, METHOD_OPTIONAL,
> @@ -6376,6 +6382,7 @@ static fwts_framework_minor_test method_tests[] = {
>   	{ method_test_S2W, "Test _S2W (S2 Device Wake State)." },
>   	{ method_test_S3W, "Test _S3W (S3 Device Wake State)." },
>   	{ method_test_S4W, "Test _S4W (S4 Device Wake State)." },
> +	{ method_test_RST, "Test _RST (Device Reset)." },
>   
>   	/* Section 7.3 OEM-Supplied System-Level Control Methods */
>   	{ method_test_S0_, "Test _S0_ (S0 System State)." },

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 7297b87..d5efb04 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -188,7 +188,7 @@ 
  * _REV  5.7.4		n/a
  * _RMV  6.3.6		Y
  * _ROM  B.4.3		Y
- * _RST  7.3.25		N
+ * _RST  7.3.25		Y
  * _RTV  11.4.10	Y
  * _S0_  7.3.4.1	Y
  * _S1_  7.3.4.2	Y
@@ -2892,6 +2892,12 @@  method_test_SxW(_S2W)
 method_test_SxW(_S3W)
 method_test_SxW(_S4W)
 
+static int method_test_RST(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_RST", NULL, 0, method_test_NULL_return, NULL);
+}
+
 static int method_test_IRC(fwts_framework *fw)
 {
 	return method_evaluate_method(fw, METHOD_OPTIONAL,
@@ -6376,6 +6382,7 @@  static fwts_framework_minor_test method_tests[] = {
 	{ method_test_S2W, "Test _S2W (S2 Device Wake State)." },
 	{ method_test_S3W, "Test _S3W (S3 Device Wake State)." },
 	{ method_test_S4W, "Test _S4W (S4 Device Wake State)." },
+	{ method_test_RST, "Test _RST (Device Reset)." },
 
 	/* Section 7.3 OEM-Supplied System-Level Control Methods */
 	{ method_test_S0_, "Test _S0_ (S0 System State)." },