| Message ID | 1439237106-18033-1-git-send-email-vivien.didelot@savoirfairelinux.com |
|---|---|
| State | Rejected |
| Headers | show |
On 10/08/2015 22:05, Vivien Didelot wrote: > Even though some bootloaders such as Barebox can boot uImage, this > format is quite U-Boot specific. So make BR2_TARGET_ROOTFS_CPIO_UIMAGE > depends on BR2_TARGET_UBOOT. What if you already have a U-Boot binary compiled by your board vendor ?
Dear Nicolas Cavallari, On Tue, 11 Aug 2015 09:26:26 +0200, Nicolas Cavallari wrote: > On 10/08/2015 22:05, Vivien Didelot wrote: > > Even though some bootloaders such as Barebox can boot uImage, this > > format is quite U-Boot specific. So make BR2_TARGET_ROOTFS_CPIO_UIMAGE > > depends on BR2_TARGET_UBOOT. > > What if you already have a U-Boot binary compiled by your board vendor ? Agreed. Even if uImage is indeed mainly U-Boot specific, I agree that you may not be building U-Boot with Buildroot, or it might be used in other contexts. I'll mark Vivien's patch as Rejected in patchwork. Thanks! Thomas
Hi Nicolas, Thomas, On 15-08-11 10:17:31, Thomas Petazzoni wrote: > Dear Nicolas Cavallari, > > On Tue, 11 Aug 2015 09:26:26 +0200, Nicolas Cavallari wrote: > > On 10/08/2015 22:05, Vivien Didelot wrote: > > > Even though some bootloaders such as Barebox can boot uImage, this > > > format is quite U-Boot specific. So make BR2_TARGET_ROOTFS_CPIO_UIMAGE > > > depends on BR2_TARGET_UBOOT. > > > > What if you already have a U-Boot binary compiled by your board vendor ? > > Agreed. Even if uImage is indeed mainly U-Boot specific, I agree that > you may not be building U-Boot with Buildroot, or it might be used in > other contexts. That is true. > I'll mark Vivien's patch as Rejected in patchwork. My initial concern was seeing the BR2_TARGET_ROOTFS_CPIO_UIMAGE entry when enabling BR2_TARGET_ROOTFS_ISO9660 (this last one depends on BR2_TARGET_GRUB, BR2_TARGET_GRUB2 or BR2_TARGET_SYSLINUX_ISOLINUX). Should we make them exclusive? config BR2_TARGET_ROOTFS_CPIO_UIMAGE depends on !BR2_TARGET_ROOTFS_ISO9660 Or is that OK to display such options? Thanks, -v
diff --git a/fs/cpio/Config.in b/fs/cpio/Config.in index 206baca..97750e2 100644 --- a/fs/cpio/Config.in +++ b/fs/cpio/Config.in @@ -50,6 +50,7 @@ endchoice config BR2_TARGET_ROOTFS_CPIO_UIMAGE bool "Create U-Boot image of the root filesystem" + depends on BR2_TARGET_UBOOT select BR2_PACKAGE_HOST_UBOOT_TOOLS help Add a U-Boot header to the cpio root filesystem. This allows
Even though some bootloaders such as Barebox can boot uImage, this format is quite U-Boot specific. So make BR2_TARGET_ROOTFS_CPIO_UIMAGE depends on BR2_TARGET_UBOOT. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- fs/cpio/Config.in | 1 + 1 file changed, 1 insertion(+)