| Message ID | 1439199585-37464-1-git-send-email-B48286@freescale.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Scott Wood |
| Headers | show |
Hi Scott, Removed both pcibios_fixup_phb and pcibios_fixup_bus. Could you please help to apply it? > -----Original Message----- > From: Zhiqiang Hou [mailto:B48286@freescale.com] > Sent: 2015年8月10日 17:40 > To: galak@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org; Wood Scott- > B07421 > Cc: Hu Mingkai-B21284; Wang Dongsheng-B40534; Hou Zhiqiang-B48286 > Subject: [PATCH V2] powerpc/85xx: Remove unused pci fixup hooks on > c293pcie > > From: Hou Zhiqiang <B48286@freescale.com> > > The c293pcie board is an endpoint device and it doesn't need PM, so > remove hooks pcibios_fixup_phb and pcibios_fixup_bus. > > Signed-off-by: Hou Zhiqiang <B48286@freescale.com> > --- > Test on c293pcie board: > V2: > Rename the title of this patch. > Remove pcibios_fixup_bus that isn't used in EP. > > arch/powerpc/platforms/85xx/c293pcie.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/powerpc/platforms/85xx/c293pcie.c > b/arch/powerpc/platforms/85xx/c293pcie.c > index 84476b6..61bc851 100644 > --- a/arch/powerpc/platforms/85xx/c293pcie.c > +++ b/arch/powerpc/platforms/85xx/c293pcie.c > @@ -66,10 +66,6 @@ define_machine(c293_pcie) { > .probe = c293_pcie_probe, > .setup_arch = c293_pcie_setup_arch, > .init_IRQ = c293_pcie_pic_init, > -#ifdef CONFIG_PCI > - .pcibios_fixup_bus = fsl_pcibios_fixup_bus, > - .pcibios_fixup_phb = fsl_pcibios_fixup_phb, > -#endif > .get_irq = mpic_get_irq, > .restart = fsl_rstcr_restart, > .calibrate_decr = generic_calibrate_decr, > -- > 2.1.0.27.g96db324 Thanks, Zhiqiang
On Tue, 2015-08-18 at 04:26 -0500, Hou Zhiqiang-B48286 wrote: > Hi Scott, > > Removed both pcibios_fixup_phb and pcibios_fixup_bus. > Could you please help to apply it? I applied it and sent a pull request yesterday. -Scott
diff --git a/arch/powerpc/platforms/85xx/c293pcie.c b/arch/powerpc/platforms/85xx/c293pcie.c index 84476b6..61bc851 100644 --- a/arch/powerpc/platforms/85xx/c293pcie.c +++ b/arch/powerpc/platforms/85xx/c293pcie.c @@ -66,10 +66,6 @@ define_machine(c293_pcie) { .probe = c293_pcie_probe, .setup_arch = c293_pcie_setup_arch, .init_IRQ = c293_pcie_pic_init, -#ifdef CONFIG_PCI - .pcibios_fixup_bus = fsl_pcibios_fixup_bus, - .pcibios_fixup_phb = fsl_pcibios_fixup_phb, -#endif .get_irq = mpic_get_irq, .restart = fsl_rstcr_restart, .calibrate_decr = generic_calibrate_decr,