diff mbox

haveged: for sparc we need generic clockgettime

Message ID 20150809084740.GA19849@waldemar-brodkorb.de
State Superseded
Headers show

Commit Message

Waldemar Brodkorb Aug. 9, 2015, 8:47 a.m. UTC
This fixes autobuilder error:
http://autobuild.buildroot.net/results/5b8bbc30f347140309ab2f81e1fe50f517356a3e/

As sparcv9 assembly is used, we need to enable generic clock_gettime
for sparcv8 systems.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/haveged/haveged.mk |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni Aug. 9, 2015, 9:19 a.m. UTC | #1
Dear Waldemar Brodkorb,

On Sun, 9 Aug 2015 10:47:40 +0200, Waldemar Brodkorb wrote:
> This fixes autobuilder error:
> http://autobuild.buildroot.net/results/5b8bbc30f347140309ab2f81e1fe50f517356a3e/
> 
> As sparcv9 assembly is used, we need to enable generic clock_gettime
> for sparcv8 systems.
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/haveged/haveged.mk |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/haveged/haveged.mk b/package/haveged/haveged.mk
> index c68f766..489564a 100644
> --- a/package/haveged/haveged.mk
> +++ b/package/haveged/haveged.mk
> @@ -9,6 +9,10 @@ HAVEGED_SITE = http://www.issihosts.com/haveged
>  HAVEGED_LICENSE = GPLv3+
>  HAVEGED_LICENSE_FILES = COPYING
>  
> +ifeq ($(BR2_sparc),y)

So this should be:

ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)

Right? We indeed don't support any SPARCv9 at the moment, but it's
probably better to be more specific. What do you think?

Thomas
Waldemar Brodkorb Aug. 9, 2015, 9:29 a.m. UTC | #2
Hi,
Thomas Petazzoni wrote,

> Dear Waldemar Brodkorb,
> 
> On Sun, 9 Aug 2015 10:47:40 +0200, Waldemar Brodkorb wrote:
> > This fixes autobuilder error:
> > http://autobuild.buildroot.net/results/5b8bbc30f347140309ab2f81e1fe50f517356a3e/
> > 
> > As sparcv9 assembly is used, we need to enable generic clock_gettime
> > for sparcv8 systems.
> > 
> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> > ---
> >  package/haveged/haveged.mk |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/package/haveged/haveged.mk b/package/haveged/haveged.mk
> > index c68f766..489564a 100644
> > --- a/package/haveged/haveged.mk
> > +++ b/package/haveged/haveged.mk
> > @@ -9,6 +9,10 @@ HAVEGED_SITE = http://www.issihosts.com/haveged
> >  HAVEGED_LICENSE = GPLv3+
> >  HAVEGED_LICENSE_FILES = COPYING
> >  
> > +ifeq ($(BR2_sparc),y)
> 
> So this should be:
> 
> ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)
> 
> Right? We indeed don't support any SPARCv9 at the moment, but it's
> probably better to be more specific. What do you think?

Right. Are you interested in sparc64 qemu defconfigs after release?

best regards
 Waldemar
Thomas Petazzoni Aug. 9, 2015, 9:40 a.m. UTC | #3
Dear Waldemar Brodkorb,

On Sun, 9 Aug 2015 11:29:10 +0200, Waldemar Brodkorb wrote:

> > So this should be:
> > 
> > ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)
> > 
> > Right? We indeed don't support any SPARCv9 at the moment, but it's
> > probably better to be more specific. What do you think?
> 
> Right.

Ok, I'll apply with this change.

> Are you interested in sparc64 qemu defconfigs after release?

Yes, sure. No need to wait after the release if these are ready. The
next branch is opened, I can merge new stuff.

Thanks,

Thomas
diff mbox

Patch

diff --git a/package/haveged/haveged.mk b/package/haveged/haveged.mk
index c68f766..489564a 100644
--- a/package/haveged/haveged.mk
+++ b/package/haveged/haveged.mk
@@ -9,6 +9,10 @@  HAVEGED_SITE = http://www.issihosts.com/haveged
 HAVEGED_LICENSE = GPLv3+
 HAVEGED_LICENSE_FILES = COPYING
 
+ifeq ($(BR2_sparc),y)
+HAVEGED_CONF_OPTS += --enable-clock_gettime=yes
+endif
+
 define HAVEGED_INSTALL_INIT_SYSV
 	$(INSTALL) -m 755 -D package/haveged/S21haveged \
 		$(TARGET_DIR)/etc/init.d/S21haveged