Message ID | 20100420091740.008171154@fluff.org.uk |
---|---|
State | Superseded |
Headers | show |
On Tue, 20 Apr 2010 10:14:10 +0100 Ben Dooks <ben@simtec.co.uk> wrote: > The driver does not support the hardware's 12 hour mode, and prints an error > on attach if the hardware is not in the supported 24 hour configuration. This > message however states that is the 24 hour mode that is not supported (and > has the minor mistake of postfixing Hour with an s). > > Fix the message to properly read that the 12 hour mode is not supported > to avoid any confusion if the hardware is in the wrong mode. > > Signed-off-by: Ben Dooks <ben@simtec.co.uk> > Cc: RTC List <rtc-linux@googlegroups.com> > Cc: Alessandro Zummo <a.zummo@towertech.it> > Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Index: b/drivers/rtc/rtc-mv.c =================================================================== --- a/drivers/rtc/rtc-mv.c 2010-02-24 18:52:17.000000000 +0000 +++ b/drivers/rtc/rtc-mv.c 2010-04-06 09:50:54.000000000 +0100 @@ -245,7 +245,7 @@ static int __devinit mv_rtc_probe(struct /* make sure the 24 hours mode is enabled */ rtc_time = readl(pdata->ioaddr + RTC_TIME_REG_OFFS); if (rtc_time & RTC_HOURS_12H_MODE) { - dev_err(&pdev->dev, "24 Hours mode not supported.\n"); + dev_err(&pdev->dev, "12 Hour mode not supported.\n"); return -EINVAL; }
The driver does not support the hardware's 12 hour mode, and prints an error on attach if the hardware is not in the supported 24 hour configuration. This message however states that is the 24 hour mode that is not supported (and has the minor mistake of postfixing Hour with an s). Fix the message to properly read that the 12 hour mode is not supported to avoid any confusion if the hardware is in the wrong mode. Signed-off-by: Ben Dooks <ben@simtec.co.uk> Cc: RTC List <rtc-linux@googlegroups.com> Cc: Alessandro Zummo <a.zummo@towertech.it> --- drivers/rtc/rtc-mv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)