| Message ID | 1438966019-19322-19-git-send-email-julien.grall@citrix.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Aug 07, 2015 at 05:46:57PM +0100, Julien Grall wrote: > The PV network protocol is using 4KB page granularity. The goal of this > patch is to allow a Linux using 64KB page granularity working as a > network backend on a non-modified Xen. > > It's only necessary to adapt the ring size and break skb data in small > chunk of 4KB. The rest of the code is relying on the grant table code. > > Signed-off-by: Julien Grall <julien.grall@citrix.com> > > --- > Cc: Ian Campbell <ian.campbell@citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > Cc: netdev@vger.kernel.org > [...] > +#define XEN_NETIF_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, XEN_PAGE_SIZE) > +#define XEN_NETIF_RX_RING_SIZE __CONST_RING_SIZE(xen_netif_rx, XEN_PAGE_SIZE) > > struct xenvif_rx_meta { > int id; > @@ -80,16 +81,18 @@ struct xenvif_rx_meta { > /* Discriminate from any valid pending_idx value. */ > #define INVALID_PENDING_IDX 0xFFFF > > -#define MAX_BUFFER_OFFSET PAGE_SIZE > +#define MAX_BUFFER_OFFSET XEN_PAGE_SIZE > > #define MAX_PENDING_REQS XEN_NETIF_TX_RING_SIZE > > +#define MAX_XEN_SKB_FRAGS (65536 / XEN_PAGE_SIZE + 1) > + It might be clearer if you add a comment saying the maximum number of frags is derived from the page size of the grant page, which happens to be XEN_PAGE_SIZE at the moment. In the future we need to figure out the page size of grant page in a dynamic way. We shall cross the bridge when we get there. > /* It's possible for an skb to have a maximal number of frags > * but still be less than MAX_BUFFER_OFFSET in size. Thus the > - * worst-case number of copy operations is MAX_SKB_FRAGS per > + * worst-case number of copy operations is MAX_XEN_SKB_FRAGS per > * ring slot. > */ > -#define MAX_GRANT_COPY_OPS (MAX_SKB_FRAGS * XEN_NETIF_RX_RING_SIZE) > +#define MAX_GRANT_COPY_OPS (MAX_XEN_SKB_FRAGS * XEN_NETIF_RX_RING_SIZE) > > #define NETBACK_INVALID_HANDLE -1 > > @@ -203,7 +206,7 @@ struct xenvif_queue { /* Per-queue data for xenvif */ > /* Maximum number of Rx slots a to-guest packet may use, including the > * slot needed for GSO meta-data. > */ > -#define XEN_NETBK_RX_SLOTS_MAX (MAX_SKB_FRAGS + 1) > +#define XEN_NETBK_RX_SLOTS_MAX ((MAX_XEN_SKB_FRAGS + 1)) > > enum state_bit_shift { > /* This bit marks that the vif is connected */ > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index 66f1780..c32a9f2 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -263,6 +263,80 @@ static struct xenvif_rx_meta *get_next_rx_buffer(struct xenvif_queue *queue, > return meta; > } > [...] > * Set up the grant operations for this fragment. If it's a flipping > * interface, we also set up the unmap request from here. > @@ -272,83 +346,52 @@ static void xenvif_gop_frag_copy(struct xenvif_queue *queue, struct sk_buff *skb > struct page *page, unsigned long size, > unsigned long offset, int *head) > { > - struct gnttab_copy *copy_gop; > - struct xenvif_rx_meta *meta; > + struct gop_frag_copy info = { > + .queue = queue, > + .npo = npo, > + .head = *head, > + .gso_type = XEN_NETIF_GSO_TYPE_NONE, > + }; > unsigned long bytes; > - int gso_type = XEN_NETIF_GSO_TYPE_NONE; > > if (skb_is_gso(skb)) { > if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4) > - gso_type = XEN_NETIF_GSO_TYPE_TCPV4; > + info.gso_type = XEN_NETIF_GSO_TYPE_TCPV4; > else if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV6) > - gso_type = XEN_NETIF_GSO_TYPE_TCPV6; > + info.gso_type = XEN_NETIF_GSO_TYPE_TCPV6; > } > > /* Data must not cross a page boundary. */ > BUG_ON(size + offset > PAGE_SIZE<<compound_order(page)); > > - meta = npo->meta + npo->meta_prod - 1; > + info.meta = npo->meta + npo->meta_prod - 1; > > /* Skip unused frames from start of page */ > page += offset >> PAGE_SHIFT; > offset &= ~PAGE_MASK; > > while (size > 0) { > - struct xen_page_foreign *foreign; > - > BUG_ON(offset >= PAGE_SIZE); > - BUG_ON(npo->copy_off > MAX_BUFFER_OFFSET); > - > - if (npo->copy_off == MAX_BUFFER_OFFSET) > - meta = get_next_rx_buffer(queue, npo); > > bytes = PAGE_SIZE - offset; > if (bytes > size) > bytes = size; > > - if (npo->copy_off + bytes > MAX_BUFFER_OFFSET) > - bytes = MAX_BUFFER_OFFSET - npo->copy_off; > - > - copy_gop = npo->copy + npo->copy_prod++; > - copy_gop->flags = GNTCOPY_dest_gref; > - copy_gop->len = bytes; > - > - foreign = xen_page_foreign(page); > - if (foreign) { > - copy_gop->source.domid = foreign->domid; > - copy_gop->source.u.ref = foreign->gref; > - copy_gop->flags |= GNTCOPY_source_gref; > - } else { > - copy_gop->source.domid = DOMID_SELF; > - copy_gop->source.u.gmfn = > - virt_to_gfn(page_address(page)); > - } > - copy_gop->source.offset = offset; > - > - copy_gop->dest.domid = queue->vif->domid; > - copy_gop->dest.offset = npo->copy_off; > - copy_gop->dest.u.ref = npo->copy_gref; > - > - npo->copy_off += bytes; > - meta->size += bytes; > - > - offset += bytes; > + info.page = page; > + gnttab_foreach_grant_in_range(page, offset, bytes, > + xenvif_gop_frag_copy_grant, > + &info); Looks like I need to at least wait until the API is settle before giving my ack. > size -= bytes; > + offset = 0; This looks wrong. Should be offset += bytes. > > - /* Next frame */ > - if (offset == PAGE_SIZE && size) { > + /* Next page */ > + if (size) { > BUG_ON(!PageCompound(page)); > page++; > - offset = 0; And this should not be deleted, I think. What is the reason for changing offset calculation? I think there is still compound page when using 64K page. > } > - > - /* Leave a gap for the GSO descriptor. */ > - if (*head && ((1 << gso_type) & queue->vif->gso_mask)) > - queue->rx.req_cons++; > - > - *head = 0; /* There must be something in this buffer now. */ > - > } > + > + *head = info.head; > } > The reset looks OK. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wei, On 08/08/2015 15:55, Wei Liu wrote: >> struct xenvif_rx_meta { >> int id; >> @@ -80,16 +81,18 @@ struct xenvif_rx_meta { >> /* Discriminate from any valid pending_idx value. */ >> #define INVALID_PENDING_IDX 0xFFFF >> >> -#define MAX_BUFFER_OFFSET PAGE_SIZE >> +#define MAX_BUFFER_OFFSET XEN_PAGE_SIZE >> >> #define MAX_PENDING_REQS XEN_NETIF_TX_RING_SIZE >> >> +#define MAX_XEN_SKB_FRAGS (65536 / XEN_PAGE_SIZE + 1) >> + > > It might be clearer if you add a comment saying the maximum number of > frags is derived from the page size of the grant page, which happens to > be XEN_PAGE_SIZE at the moment. Will do. > In the future we need to figure out the page size of grant page in a > dynamic way. We shall cross the bridge when we get there. Right, there is few other places where we would need to do that too (see MAX_BUFFER_OFFSET for instance). [..] >> + info.page = page; >> + gnttab_foreach_grant_in_range(page, offset, bytes, >> + xenvif_gop_frag_copy_grant, >> + &info); > > Looks like I need to at least wait until the API is settle before giving > my ack. > >> size -= bytes; >> + offset = 0; > > This looks wrong. Should be offset += bytes. With the new implementation of the loop, each iteration will be on a different page. So only the first page has an offset different than zero. > >> >> - /* Next frame */ >> - if (offset == PAGE_SIZE && size) { >> + /* Next page */ >> + if (size) { >> BUG_ON(!PageCompound(page)); >> page++; >> - offset = 0; > > And this should not be deleted, I think. > > What is the reason for changing offset calculation? I think there is > still compound page when using 64K page. The compound pages are still working ... gnttab_foreach_grant_in_range is called once per page. So the offset can be reset to 0 every time. No need to add code which would make the result less clear. We only need to know if the size is not 0 to get the next page. The patch may not be clear enough to see it's working so I've copied the result loop below: while (size > 0) { BUG_ON(offset >= PAGE_SIZE); bytes = PAGE_SIZE - offset; if (bytes > size) bytes = size; info.page = page; gnttab_foreach_grant_in_range(page, offset, bytes, xenvif_gop_frag_copy_grant, &info); size -= bytes; offset = 0; /* Next page */ if (size) { BUG_ON(!PageCompound(page)); page++; } } Regards,
On Mon, Aug 10, 2015 at 10:57:48AM +0100, Julien Grall wrote: [...] > > >>+ info.page = page; > >>+ gnttab_foreach_grant_in_range(page, offset, bytes, > >>+ xenvif_gop_frag_copy_grant, > >>+ &info); > > > >Looks like I need to at least wait until the API is settle before giving > >my ack. > > > >> size -= bytes; > >>+ offset = 0; > > > >This looks wrong. Should be offset += bytes. > > With the new implementation of the loop, each iteration will be on a > different page. > So only the first page has an offset different than zero. > > > > >> > >>- /* Next frame */ > >>- if (offset == PAGE_SIZE && size) { > >>+ /* Next page */ > >>+ if (size) { > >> BUG_ON(!PageCompound(page)); > >> page++; > >>- offset = 0; > > > >And this should not be deleted, I think. > > > >What is the reason for changing offset calculation? I think there is > >still compound page when using 64K page. > > The compound pages are still working ... gnttab_foreach_grant_in_range is > called once per page. So the offset can be reset to 0 every time. No need to > add code which would make the result less clear. > > We only need to know if the size is not 0 to get the next page. > > The patch may not be clear enough to see it's working so I've copied the > result loop below: > > while (size > 0) { > BUG_ON(offset >= PAGE_SIZE); > > bytes = PAGE_SIZE - offset; > if (bytes > size) > bytes = size; > > info.page = page; > gnttab_foreach_grant_in_range(page, offset, bytes, > xenvif_gop_frag_copy_grant, > &info); > size -= bytes; > offset = 0; > > /* Next page */ > if (size) { > BUG_ON(!PageCompound(page)); > page++; > } > } > Right. That doesn't mean the original code was wrong or anything. But I don't want to bikeshed about this. Please add a comment saying that offset is always 0 starting from second iteration because the gnttab_foreach_grant_in_range makes sure we handle one page in one go. Wei. > Regards, > > -- > Julien Grall -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/08/15 12:39, Wei Liu wrote: > On Mon, Aug 10, 2015 at 10:57:48AM +0100, Julien Grall wrote: >> while (size > 0) { >> BUG_ON(offset >= PAGE_SIZE); >> >> bytes = PAGE_SIZE - offset; >> if (bytes > size) >> bytes = size; >> >> info.page = page; >> gnttab_foreach_grant_in_range(page, offset, bytes, >> xenvif_gop_frag_copy_grant, >> &info); >> size -= bytes; >> offset = 0; >> >> /* Next page */ >> if (size) { >> BUG_ON(!PageCompound(page)); >> page++; >> } >> } >> > > Right. That doesn't mean the original code was wrong or anything. But I > don't want to bikeshed about this. I never said the original code was wrong... The original code was allowing the possibility to copy less data than the length contained in page. In the new version, it has been pushed with the callback xenvif_gop_frag_copy_grant. > Please add a comment saying that offset is always 0 starting from second > iteration because the gnttab_foreach_grant_in_range makes sure we handle > one page in one go. I think this is superfluous. To be honest, the comment should have been on the original version and not in the new one. The construction of the loop was far from obvious that we copied less data. In this new version, the reason is not because of gnttab_foreach_grant_in_range is always a page but how the loop has been constructed. If you look how bytes has been defined, it will always contain min(PAGE_SIZE - offset, size) So for the first page, this will be PAGE_SIZE - offset. A the end of the loop we reset the offset 0, indeed we copy all the data of the first page. For the second page and onwards this will always be PAGE_SIZE except for the last one where we took size. Regards,
diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 8a495b3..bb68211 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -44,6 +44,7 @@ #include <xen/interface/grant_table.h> #include <xen/grant_table.h> #include <xen/xenbus.h> +#include <xen/page.h> #include <linux/debugfs.h> typedef unsigned int pending_ring_idx_t; @@ -64,8 +65,8 @@ struct pending_tx_info { struct ubuf_info callback_struct; }; -#define XEN_NETIF_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, PAGE_SIZE) -#define XEN_NETIF_RX_RING_SIZE __CONST_RING_SIZE(xen_netif_rx, PAGE_SIZE) +#define XEN_NETIF_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, XEN_PAGE_SIZE) +#define XEN_NETIF_RX_RING_SIZE __CONST_RING_SIZE(xen_netif_rx, XEN_PAGE_SIZE) struct xenvif_rx_meta { int id; @@ -80,16 +81,18 @@ struct xenvif_rx_meta { /* Discriminate from any valid pending_idx value. */ #define INVALID_PENDING_IDX 0xFFFF -#define MAX_BUFFER_OFFSET PAGE_SIZE +#define MAX_BUFFER_OFFSET XEN_PAGE_SIZE #define MAX_PENDING_REQS XEN_NETIF_TX_RING_SIZE +#define MAX_XEN_SKB_FRAGS (65536 / XEN_PAGE_SIZE + 1) + /* It's possible for an skb to have a maximal number of frags * but still be less than MAX_BUFFER_OFFSET in size. Thus the - * worst-case number of copy operations is MAX_SKB_FRAGS per + * worst-case number of copy operations is MAX_XEN_SKB_FRAGS per * ring slot. */ -#define MAX_GRANT_COPY_OPS (MAX_SKB_FRAGS * XEN_NETIF_RX_RING_SIZE) +#define MAX_GRANT_COPY_OPS (MAX_XEN_SKB_FRAGS * XEN_NETIF_RX_RING_SIZE) #define NETBACK_INVALID_HANDLE -1 @@ -203,7 +206,7 @@ struct xenvif_queue { /* Per-queue data for xenvif */ /* Maximum number of Rx slots a to-guest packet may use, including the * slot needed for GSO meta-data. */ -#define XEN_NETBK_RX_SLOTS_MAX (MAX_SKB_FRAGS + 1) +#define XEN_NETBK_RX_SLOTS_MAX ((MAX_XEN_SKB_FRAGS + 1)) enum state_bit_shift { /* This bit marks that the vif is connected */ diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 66f1780..c32a9f2 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -263,6 +263,80 @@ static struct xenvif_rx_meta *get_next_rx_buffer(struct xenvif_queue *queue, return meta; } +struct gop_frag_copy { + struct xenvif_queue *queue; + struct netrx_pending_operations *npo; + struct xenvif_rx_meta *meta; + int head; + int gso_type; + + struct page *page; +}; + +static void xenvif_setup_copy_gop(unsigned long gfn, + unsigned int offset, + unsigned int *len, + struct gop_frag_copy *info) +{ + struct gnttab_copy *copy_gop; + struct xen_page_foreign *foreign; + /* Convenient aliases */ + struct xenvif_queue *queue = info->queue; + struct netrx_pending_operations *npo = info->npo; + struct page *page = info->page; + + BUG_ON(npo->copy_off > MAX_BUFFER_OFFSET); + + if (npo->copy_off == MAX_BUFFER_OFFSET) + info->meta = get_next_rx_buffer(queue, npo); + + if (npo->copy_off + *len > MAX_BUFFER_OFFSET) + *len = MAX_BUFFER_OFFSET - npo->copy_off; + + copy_gop = npo->copy + npo->copy_prod++; + copy_gop->flags = GNTCOPY_dest_gref; + copy_gop->len = *len; + + foreign = xen_page_foreign(page); + if (foreign) { + copy_gop->source.domid = foreign->domid; + copy_gop->source.u.ref = foreign->gref; + copy_gop->flags |= GNTCOPY_source_gref; + } else { + copy_gop->source.domid = DOMID_SELF; + copy_gop->source.u.gmfn = gfn; + } + copy_gop->source.offset = offset; + + copy_gop->dest.domid = queue->vif->domid; + copy_gop->dest.offset = npo->copy_off; + copy_gop->dest.u.ref = npo->copy_gref; + + npo->copy_off += *len; + info->meta->size += *len; + + /* Leave a gap for the GSO descriptor. */ + if (info->head && ((1 << info->gso_type) & queue->vif->gso_mask)) + queue->rx.req_cons++; + + info->head = 0; /* There must be something in this buffer now */ +} + +static void xenvif_gop_frag_copy_grant(unsigned long gfn, + unsigned offset, + unsigned int len, + void *data) +{ + unsigned int bytes; + + while (len) { + bytes = len; + xenvif_setup_copy_gop(gfn, offset, &bytes, data); + offset += bytes; + len -= bytes; + } +} + /* * Set up the grant operations for this fragment. If it's a flipping * interface, we also set up the unmap request from here. @@ -272,83 +346,52 @@ static void xenvif_gop_frag_copy(struct xenvif_queue *queue, struct sk_buff *skb struct page *page, unsigned long size, unsigned long offset, int *head) { - struct gnttab_copy *copy_gop; - struct xenvif_rx_meta *meta; + struct gop_frag_copy info = { + .queue = queue, + .npo = npo, + .head = *head, + .gso_type = XEN_NETIF_GSO_TYPE_NONE, + }; unsigned long bytes; - int gso_type = XEN_NETIF_GSO_TYPE_NONE; if (skb_is_gso(skb)) { if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4) - gso_type = XEN_NETIF_GSO_TYPE_TCPV4; + info.gso_type = XEN_NETIF_GSO_TYPE_TCPV4; else if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV6) - gso_type = XEN_NETIF_GSO_TYPE_TCPV6; + info.gso_type = XEN_NETIF_GSO_TYPE_TCPV6; } /* Data must not cross a page boundary. */ BUG_ON(size + offset > PAGE_SIZE<<compound_order(page)); - meta = npo->meta + npo->meta_prod - 1; + info.meta = npo->meta + npo->meta_prod - 1; /* Skip unused frames from start of page */ page += offset >> PAGE_SHIFT; offset &= ~PAGE_MASK; while (size > 0) { - struct xen_page_foreign *foreign; - BUG_ON(offset >= PAGE_SIZE); - BUG_ON(npo->copy_off > MAX_BUFFER_OFFSET); - - if (npo->copy_off == MAX_BUFFER_OFFSET) - meta = get_next_rx_buffer(queue, npo); bytes = PAGE_SIZE - offset; if (bytes > size) bytes = size; - if (npo->copy_off + bytes > MAX_BUFFER_OFFSET) - bytes = MAX_BUFFER_OFFSET - npo->copy_off; - - copy_gop = npo->copy + npo->copy_prod++; - copy_gop->flags = GNTCOPY_dest_gref; - copy_gop->len = bytes; - - foreign = xen_page_foreign(page); - if (foreign) { - copy_gop->source.domid = foreign->domid; - copy_gop->source.u.ref = foreign->gref; - copy_gop->flags |= GNTCOPY_source_gref; - } else { - copy_gop->source.domid = DOMID_SELF; - copy_gop->source.u.gmfn = - virt_to_gfn(page_address(page)); - } - copy_gop->source.offset = offset; - - copy_gop->dest.domid = queue->vif->domid; - copy_gop->dest.offset = npo->copy_off; - copy_gop->dest.u.ref = npo->copy_gref; - - npo->copy_off += bytes; - meta->size += bytes; - - offset += bytes; + info.page = page; + gnttab_foreach_grant_in_range(page, offset, bytes, + xenvif_gop_frag_copy_grant, + &info); size -= bytes; + offset = 0; - /* Next frame */ - if (offset == PAGE_SIZE && size) { + /* Next page */ + if (size) { BUG_ON(!PageCompound(page)); page++; - offset = 0; } - - /* Leave a gap for the GSO descriptor. */ - if (*head && ((1 << gso_type) & queue->vif->gso_mask)) - queue->rx.req_cons++; - - *head = 0; /* There must be something in this buffer now. */ - } + + *head = info.head; } /* @@ -747,7 +790,7 @@ static int xenvif_count_requests(struct xenvif_queue *queue, first->size -= txp->size; slots++; - if (unlikely((txp->offset + txp->size) > PAGE_SIZE)) { + if (unlikely((txp->offset + txp->size) > XEN_PAGE_SIZE)) { netdev_err(queue->vif->dev, "Cross page boundary, txp->offset: %u, size: %u\n", txp->offset, txp->size); xenvif_fatal_tx_err(queue->vif); @@ -1241,11 +1284,11 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, } /* No crossing a page as the payload mustn't fragment. */ - if (unlikely((txreq.offset + txreq.size) > PAGE_SIZE)) { + if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) { netdev_err(queue->vif->dev, "txreq.offset: %u, size: %u, end: %lu\n", txreq.offset, txreq.size, - (unsigned long)(txreq.offset&~PAGE_MASK) + txreq.size); + (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size); xenvif_fatal_tx_err(queue->vif); break; } @@ -1287,7 +1330,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, virt_to_gfn(skb->data); queue->tx_copy_ops[*copy_ops].dest.domid = DOMID_SELF; queue->tx_copy_ops[*copy_ops].dest.offset = - offset_in_page(skb->data); + offset_in_page(skb->data) & ~XEN_PAGE_MASK; queue->tx_copy_ops[*copy_ops].len = data_len; queue->tx_copy_ops[*copy_ops].flags = GNTCOPY_source_gref; @@ -1780,7 +1823,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue, goto err; txs = (struct xen_netif_tx_sring *)addr; - BACK_RING_INIT(&queue->tx, txs, PAGE_SIZE); + BACK_RING_INIT(&queue->tx, txs, XEN_PAGE_SIZE); err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif), &rx_ring_ref, 1, &addr); @@ -1788,7 +1831,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue, goto err; rxs = (struct xen_netif_rx_sring *)addr; - BACK_RING_INIT(&queue->rx, rxs, PAGE_SIZE); + BACK_RING_INIT(&queue->rx, rxs, XEN_PAGE_SIZE); return 0;
The PV network protocol is using 4KB page granularity. The goal of this patch is to allow a Linux using 64KB page granularity working as a network backend on a non-modified Xen. It's only necessary to adapt the ring size and break skb data in small chunk of 4KB. The rest of the code is relying on the grant table code. Signed-off-by: Julien Grall <julien.grall@citrix.com> --- Cc: Ian Campbell <ian.campbell@citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> Cc: netdev@vger.kernel.org Improvement such as support of 64KB grant is not taken into consideration in this patch because we have the requirement to run a Linux using 64KB pages on a non-modified Xen. Changes in v3: - Fix errors reported by checkpatch.pl - s/mfn/gfn/ based on the new naming - gnttab_foreach_grant has been renamed to gnttab_forach_grant_in_range - The grant callback doesn't allow anymore to use less data. An helpers has been added in netback to handle this. Changes in v2: - Correctly set MAX_GRANT_COPY_OPS and XEN_NETBK_RX_SLOTS_MAX - Don't use XEN_PAGE_SIZE in handle_frag_list as we coalesce fragment into a new skb - Use gnntab_foreach_grant to split a Linux page into grant --- drivers/net/xen-netback/common.h | 15 ++-- drivers/net/xen-netback/netback.c | 153 ++++++++++++++++++++++++-------------- 2 files changed, 107 insertions(+), 61 deletions(-)