diff mbox

[15/19] resize2fs: Remove duplicit condition

Message ID 1438944689-24562-16-git-send-email-jack@suse.com
State Accepted, archived
Headers show

Commit Message

Jan Kara Aug. 7, 2015, 10:51 a.m. UTC
Signed-off-by: Jan Kara <jack@suse.com>
---
 resize/resize2fs.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Comments

Andreas Dilger Aug. 7, 2015, 7:01 p.m. UTC | #1
On Aug 7, 2015, at 4:51 AM, Jan Kara <jack@suse.com> wrote:
> Subject: [PATCH 15/19] resize2fs: Remove duplicit condition


Minor typo - s/duplicit/duplicate/

> Signed-off-by: Jan Kara <jack@suse.com>
> ---
> resize/resize2fs.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/resize/resize2fs.c b/resize/resize2fs.c
> index 9a8be30bbce1..22300836300d 100644
> --- a/resize/resize2fs.c
> +++ b/resize/resize2fs.c
> @@ -682,19 +682,9 @@ static errcode_t adjust_superblock(ext2_resize_t rfs, blk64_t new_size)
> 	}
> 
> 	/*
> -	 * If we are shrinking the number block groups, we're done and
> +	 * If we are not increasing the number block groups, we're done and
> 	 * can exit now.
> 	 */
> -	if (rfs->old_fs->group_desc_count > fs->group_desc_count) {
> -		retval = 0;
> -		goto errout;
> -	}
> -
> -	/*
> -	 * If the number of block groups is staying the same, we're
> -	 * done and can exit now.  (If the number block groups is
> -	 * shrinking, we had exited earlier.)
> -	 */
> 	if (rfs->old_fs->group_desc_count >= fs->group_desc_count) {
> 		retval = 0;
> 		goto errout;
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kara Aug. 26, 2015, 4:12 p.m. UTC | #2
On Fri 07-08-15 13:01:13, Andreas Dilger wrote:
> On Aug 7, 2015, at 4:51 AM, Jan Kara <jack@suse.com> wrote:
> > Subject: [PATCH 15/19] resize2fs: Remove duplicit condition
> 
> 
> Minor typo - s/duplicit/duplicate/

Thanks. Fixed.

								Honza

> 
> > Signed-off-by: Jan Kara <jack@suse.com>
> > ---
> > resize/resize2fs.c | 12 +-----------
> > 1 file changed, 1 insertion(+), 11 deletions(-)
> > 
> > diff --git a/resize/resize2fs.c b/resize/resize2fs.c
> > index 9a8be30bbce1..22300836300d 100644
> > --- a/resize/resize2fs.c
> > +++ b/resize/resize2fs.c
> > @@ -682,19 +682,9 @@ static errcode_t adjust_superblock(ext2_resize_t rfs, blk64_t new_size)
> > 	}
> > 
> > 	/*
> > -	 * If we are shrinking the number block groups, we're done and
> > +	 * If we are not increasing the number block groups, we're done and
> > 	 * can exit now.
> > 	 */
> > -	if (rfs->old_fs->group_desc_count > fs->group_desc_count) {
> > -		retval = 0;
> > -		goto errout;
> > -	}
> > -
> > -	/*
> > -	 * If the number of block groups is staying the same, we're
> > -	 * done and can exit now.  (If the number block groups is
> > -	 * shrinking, we had exited earlier.)
> > -	 */
> > 	if (rfs->old_fs->group_desc_count >= fs->group_desc_count) {
> > 		retval = 0;
> > 		goto errout;
> > -- 
> > 2.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> Cheers, Andreas
> 
> 
> 
> 
> 
>
diff mbox

Patch

diff --git a/resize/resize2fs.c b/resize/resize2fs.c
index 9a8be30bbce1..22300836300d 100644
--- a/resize/resize2fs.c
+++ b/resize/resize2fs.c
@@ -682,19 +682,9 @@  static errcode_t adjust_superblock(ext2_resize_t rfs, blk64_t new_size)
 	}
 
 	/*
-	 * If we are shrinking the number block groups, we're done and
+	 * If we are not increasing the number block groups, we're done and
 	 * can exit now.
 	 */
-	if (rfs->old_fs->group_desc_count > fs->group_desc_count) {
-		retval = 0;
-		goto errout;
-	}
-
-	/*
-	 * If the number of block groups is staying the same, we're
-	 * done and can exit now.  (If the number block groups is
-	 * shrinking, we had exited earlier.)
-	 */
 	if (rfs->old_fs->group_desc_count >= fs->group_desc_count) {
 		retval = 0;
 		goto errout;