| Message ID | 1438877771-23513-16-git-send-email-kishon@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Thursday, August 06, 2015 at 06:16:05 PM, Kishon Vijay Abraham I wrote: > xhci omap driver has board_usb_init in xhci_hcd_init but doesn't have > the corresponding cleanup function in xhci_hcd_stop. > > Fix it here by invoking board_usb_cleanup() in xhci_hcd_stop(). > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/usb/host/xhci-omap.c | 1 + > 1 file changed, 1 insertion(+) It's be really cool if you could at least place the additions to drivers/usb/* at the beginning of the series, so you're not just doing patching at random places throughout the series ;-) Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
Hi, On Friday 07 August 2015 03:58 AM, Marek Vasut wrote: > On Thursday, August 06, 2015 at 06:16:05 PM, Kishon Vijay Abraham I wrote: >> xhci omap driver has board_usb_init in xhci_hcd_init but doesn't have >> the corresponding cleanup function in xhci_hcd_stop. >> >> Fix it here by invoking board_usb_cleanup() in xhci_hcd_stop(). >> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> --- >> drivers/usb/host/xhci-omap.c | 1 + >> 1 file changed, 1 insertion(+) > > It's be really cool if you could at least place the additions to drivers/usb/* > at the beginning of the series, so you're not just doing patching at random > places throughout the series ;-) yeah, I just consolidated all the fixes in my working tree and sent it. I'll split them into separate series and send them again. Thanks Kishon
On Monday, August 10, 2015 at 08:00:25 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 07 August 2015 03:58 AM, Marek Vasut wrote: > > On Thursday, August 06, 2015 at 06:16:05 PM, Kishon Vijay Abraham I wrote: > >> xhci omap driver has board_usb_init in xhci_hcd_init but doesn't have > >> the corresponding cleanup function in xhci_hcd_stop. > >> > >> Fix it here by invoking board_usb_cleanup() in xhci_hcd_stop(). > >> > >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > >> --- > >> > >> drivers/usb/host/xhci-omap.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > It's be really cool if you could at least place the additions to > > drivers/usb/* at the beginning of the series, so you're not just doing > > patching at random places throughout the series ;-) > > yeah, I just consolidated all the fixes in my working tree and sent it. > I'll split them into separate series and send them again. Cool, thanks! Best regards, Marek Vasut
diff --git a/drivers/usb/host/xhci-omap.c b/drivers/usb/host/xhci-omap.c index 3a55208..104e7a7 100644 --- a/drivers/usb/host/xhci-omap.c +++ b/drivers/usb/host/xhci-omap.c @@ -96,4 +96,5 @@ void xhci_hcd_stop(int index) struct omap_xhci *ctx = &omap; omap_xhci_core_exit(ctx); + board_usb_cleanup(index, USB_INIT_HOST); }
xhci omap driver has board_usb_init in xhci_hcd_init but doesn't have the corresponding cleanup function in xhci_hcd_stop. Fix it here by invoking board_usb_cleanup() in xhci_hcd_stop(). Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/usb/host/xhci-omap.c | 1 + 1 file changed, 1 insertion(+)