Patchwork [qemu-iotests] explicitly use bash interpreter

login
register
mail settings
Submitter Stefan Hajnoczi
Date April 19, 2010, 11:10 a.m.
Message ID <1271675403-12309-1-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/50457/
State New
Headers show

Comments

Stefan Hajnoczi - April 19, 2010, 11:10 a.m.
From: Stefan Hajnoczi <stefanha@gmail.com>

The tests use bash language features including 'local' and 'let' which
aren't supported by /bin/sh on systems that use a conservative shell
like dash.  This patch changes the interpreter to /bin/bash.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 001            |    2 +-
 002            |    2 +-
 003            |    2 +-
 004            |    2 +-
 005            |    2 +-
 006            |    2 +-
 007            |    2 +-
 008            |    2 +-
 009            |    2 +-
 010            |    2 +-
 011            |    2 +-
 012            |    2 +-
 013            |    2 +-
 014            |    2 +-
 015            |    2 +-
 016            |    2 +-
 017            |    2 +-
 018            |    2 +-
 019            |    2 +-
 020            |    2 +-
 021            |    2 +-
 022            |    2 +-
 023            |    2 +-
 024            |    2 +-
 check          |    2 +-
 common         |    2 +-
 common.config  |    2 +-
 common.filter  |    2 +-
 common.pattern |    2 +-
 common.rc      |    2 +-
 30 files changed, 30 insertions(+), 30 deletions(-)
Jamie Lokier - April 19, 2010, 12:27 p.m.
Stefan Hajnoczi wrote:
> From: Stefan Hajnoczi <stefanha@gmail.com>
> 
> The tests use bash language features including 'local' and 'let' which
> aren't supported by /bin/sh on systems that use a conservative shell
> like dash.  This patch changes the interpreter to /bin/bash.

Minor nit: Dash does support 'local'.

-- Jamie

Patch

diff --git a/001 b/001
index bb96dca..fe66a8e 100755
--- a/001
+++ b/001
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test simple read/write using plain bdrv_read/bdrv_write
 #
diff --git a/002 b/002
index a634e1e..57af974 100755
--- a/002
+++ b/002
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test simple read/write using plain bdrv_pread/bdrv_pwrite
 #
diff --git a/003 b/003
index 23a406e..656da99 100755
--- a/003
+++ b/003
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test simple read/write using bdrv_aio_readv/bdrv_aio_writev
 #
diff --git a/004 b/004
index 0c45845..3de7ed8 100755
--- a/004
+++ b/004
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Make sure we can't read and write outside of the image size.
 #
diff --git a/005 b/005
index 1debdc4..480276b 100755
--- a/005
+++ b/005
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Make sure qemu-img can create 5TB images
 #
diff --git a/006 b/006
index 58b8213..98ef4ea 100755
--- a/006
+++ b/006
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Make sure qemu-img rejects > 127GB images for the vpc format as the format
 # doesn't support this.
diff --git a/007 b/007
index b2b6df3..2de1aa4 100755
--- a/007
+++ b/007
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Check for one possible case of qcow2 refcount corruption.
 #
diff --git a/008 b/008
index 26d1102..b697deb 100755
--- a/008
+++ b/008
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test simple asynchronous read/write operations.
 #
diff --git a/009 b/009
index ebcc8de..1499b77 100755
--- a/009
+++ b/009
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Nolan I qcow2 corruption - incorrectly reports free clusters
 #
diff --git a/010 b/010
index 2cb5eeb..440e9f6 100755
--- a/010
+++ b/010
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Nolan II qcow2 corruption - wrong used cluster
 #
diff --git a/011 b/011
index 9106e74..87b4082 100755
--- a/011
+++ b/011
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test for AIO allocation on the same cluster
 #
diff --git a/012 b/012
index a1b45fc..32a2647 100755
--- a/012
+++ b/012
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Make sure we can open read-only images
 #
diff --git a/013 b/013
index bd9fdef..0671bf6 100755
--- a/013
+++ b/013
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # qcow2 pattern test, empty and compressed image - 4k cluster patterns
 #
diff --git a/014 b/014
index ee7bf21..f38af43 100755
--- a/014
+++ b/014
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # qcow2 pattern test, complex patterns including compression and snapshots
 # Using patterns for 4k cluster size.
diff --git a/015 b/015
index 34b475f..f3b0acc 100755
--- a/015
+++ b/015
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Combined test to grow the refcount table and test snapshots.
 #
diff --git a/016 b/016
index 1dbdcb5..e09ab86 100755
--- a/016
+++ b/016
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test I/O after EOF for growable images.
 #
diff --git a/017 b/017
index 1580ef7..d861961 100755
--- a/017
+++ b/017
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Simple backing file reads
 #
diff --git a/018 b/018
index c6233f1..0a348fe 100755
--- a/018
+++ b/018
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Merge backing file into test image when converting the image
 #
diff --git a/019 b/019
index 20893c5..711255e 100755
--- a/019
+++ b/019
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # When using a backing file for the output image in qemu-img convert,
 # the backing file clusters must not copied. The data must still be
diff --git a/020 b/020
index 4c9778d..546e074 100755
--- a/020
+++ b/020
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Commit changes to backing file
 #
diff --git a/021 b/021
index c0241ae..eb61230 100755
--- a/021
+++ b/021
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test handling of invalid patterns arguments to qemu-io
 #
diff --git a/022 b/022
index ccf2319..635ad14 100755
--- a/022
+++ b/022
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Test bdrv_load/save_vmstate using the usual patterns
 #
diff --git a/023 b/023
index 883ca47..55c5be7 100755
--- a/023
+++ b/023
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # qcow2 pattern test with various cluster sizes
 #
diff --git a/024 b/024
index 3cad287..2b2ebf1 100755
--- a/024
+++ b/024
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Rebasing COW images
 #
diff --git a/check b/check
index 8652e8c..e0eaa7a 100755
--- a/check
+++ b/check
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Copyright (C) 2009 Red Hat, Inc.
 # Copyright (c) 2000-2002,2006 Silicon Graphics, Inc.  All Rights Reserved.
diff --git a/common b/common
index c246766..988fd5e 100644
--- a/common
+++ b/common
@@ -1,4 +1,4 @@ 
-#!/bin/sh 
+#!/bin/bash
 #
 # Copyright (C) 2009 Red Hat, Inc.
 # Copyright (c) 2000-2005 Silicon Graphics, Inc.  All Rights Reserved.
diff --git a/common.config b/common.config
index cbbf39d..bdd0530 100644
--- a/common.config
+++ b/common.config
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Copyright (C) 2009 Red Hat, Inc.
 # Copyright (c) 2000-2003,2006 Silicon Graphics, Inc.  All Rights Reserved.
diff --git a/common.filter b/common.filter
index ba464a5..ce81266 100644
--- a/common.filter
+++ b/common.filter
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Copyright (C) 2009 Red Hat, Inc.
 # Copyright (c) 2000-2001 Silicon Graphics, Inc.  All Rights Reserved.
diff --git a/common.pattern b/common.pattern
index a40d0d0..c2b84b8 100644
--- a/common.pattern
+++ b/common.pattern
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Copyright (C) 2009 Red Hat, Inc.
 #
diff --git a/common.rc b/common.rc
index 0a7ba00..da58f92 100644
--- a/common.rc
+++ b/common.rc
@@ -1,4 +1,4 @@ 
-#!/bin/sh
+#!/bin/bash
 #
 # Copyright (C) 2009 Red Hat, Inc.
 # Copyright (c) 2000-2006 Silicon Graphics, Inc.  All Rights Reserved.