| Message ID | l2geb3ff54b1004190250qfe606c28i80dab5f156128f4c@mail.gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Rami Rosen <ramirose@gmail.com> Date: Mon, 19 Apr 2010 12:50:19 +0300 > There is no need to export skb_under_panic() and skb_over_panic() in > skbuff.c, since these methods are used only in > skbuff.c ; this patch removes these two exports. > > Signed-off-by: Rami Rosen <ramirose@gmail.com> If this is indeed the case, you should also mark these functions 'static' and remove the extern declarations of them from include/linux/skbuff.h Please make those changes and resubmit your patch (against net-next-2.6 since that's where it belongs at this point). Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 93c4e06..799b89d 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -126,7 +126,6 @@ void skb_over_panic(struct sk_buff *skb, int sz, void *here) skb->dev ? skb->dev->name : "<NULL>"); BUG(); } -EXPORT_SYMBOL(skb_over_panic); /** * skb_under_panic - private function @@ -146,7 +145,6 @@ void skb_under_panic(struct sk_buff *skb, int sz, void *here) skb->dev ? skb->dev->name : "<NULL>"); BUG(); } -EXPORT_SYMBOL(skb_under_panic); /* Allocate a new skbuff. We do this ourselves so we can fill in a few * 'private' fields and also do memory statistics to find all the
Hi, There is no need to export skb_under_panic() and skb_over_panic() in skbuff.c, since these methods are used only in skbuff.c ; this patch removes these two exports. Regards, Rami Rosen Signed-off-by: Rami Rosen <ramirose@gmail.com>