| Message ID | 1438711241-31792-10-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, All, On 2015-08-04 20:00 +0200, Thomas Petazzoni spake thusly: > mpd requires at least gcc 4.6, so use the newly introduced gcc version > dependency mechanism instead of open-coded toolchain dependencies. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/mpd/Config.in | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/package/mpd/Config.in b/package/mpd/Config.in > index 65b46df..28962f7 100644 > --- a/package/mpd/Config.in > +++ b/package/mpd/Config.in > @@ -4,9 +4,7 @@ menuconfig BR2_PACKAGE_MPD > depends on BR2_USE_WCHAR # libglib2, flac > depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > depends on BR2_USE_MMU # libglib2 > - # sparc & CS powerpc gcc are too old > - depends on !BR2_sparc > - depends on !(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 || BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009) > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 > depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS > select BR2_PACKAGE_BOOST > select BR2_PACKAGE_LIBGLIB2 > @@ -297,9 +295,8 @@ config BR2_PACKAGE_MPD_UPNP > > endif > > -comment "mpd needs a toolchain w/ C++, threads, wchar" > +comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6" > depends on BR2_USE_MMU > depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS > - depends on !BR2_sparc > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > - !BR2_TOOLCHAIN_HAS_THREADS > + !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 > -- > 2.5.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/mpd/Config.in b/package/mpd/Config.in index 65b46df..28962f7 100644 --- a/package/mpd/Config.in +++ b/package/mpd/Config.in @@ -4,9 +4,7 @@ menuconfig BR2_PACKAGE_MPD depends on BR2_USE_WCHAR # libglib2, flac depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 depends on BR2_USE_MMU # libglib2 - # sparc & CS powerpc gcc are too old - depends on !BR2_sparc - depends on !(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 || BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009) + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS select BR2_PACKAGE_BOOST select BR2_PACKAGE_LIBGLIB2 @@ -297,9 +295,8 @@ config BR2_PACKAGE_MPD_UPNP endif -comment "mpd needs a toolchain w/ C++, threads, wchar" +comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6" depends on BR2_USE_MMU depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS - depends on !BR2_sparc depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS + !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
mpd requires at least gcc 4.6, so use the newly introduced gcc version dependency mechanism instead of open-coded toolchain dependencies. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/mpd/Config.in | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)