| Message ID | 1438621878-1113072-4-git-send-email-tom@herbertland.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Aug 3, 2015 at 10:11 AM, Tom Herbert <tom@herbertland.com> wrote: > For GRO to work with sit we need gro_receive and gro_complete populated > in the sit_offload structure. > > Signed-off-by: Tom Herbert <tom@herbertland.com> You might want to checkout the recent history on this file unless there's something that's changed in the last couple of weeks: commit fdbf5b097bbd9693a86c0b8bfdd071a9a2117cfc Author: Herbert Xu <herbert@gondor.apana.org.au> Date: Mon Jul 20 17:55:38 2015 +0800 Revert "sit: Add gro callbacks to sit_offload" This patch reverts 19424e052fb44da2f00d1a868cbb51f3e9f4bbb5 ("sit: Add gro callbacks to sit_offload") because it generates packets that cannot be handled even by our own GSO. Reported-by: Wolfgang Walter <linux@stwm.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 08b6204..e893cd1 100644 --- a/net/ipv6/ip6_offload.c +++ b/net/ipv6/ip6_offload.c @@ -292,6 +292,8 @@ static struct packet_offload ipv6_packet_offload __read_mostly = { static const struct net_offload sit_offload = { .callbacks = { .gso_segment = ipv6_gso_segment, + .gro_receive = ipv6_gro_receive, + .gro_complete = ipv6_gro_complete, }, };
For GRO to work with sit we need gro_receive and gro_complete populated in the sit_offload structure. Signed-off-by: Tom Herbert <tom@herbertland.com> --- net/ipv6/ip6_offload.c | 2 ++ 1 file changed, 2 insertions(+)