diff mbox

[2/3] package/eflutils: needs argp-standalone with musl toolchains

Message ID 1438448118-26198-2-git-send-email-romain.naour@openwide.fr
State Changes Requested
Headers show

Commit Message

Romain Naour Aug. 1, 2015, 4:55 p.m. UTC
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/elfutils/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Aug. 2, 2015, 3:26 p.m. UTC | #1
Romain, All,

On 2015-08-01 18:55 +0200, Romain Naour spake thusly:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/elfutils/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/elfutils/Config.in b/package/elfutils/Config.in
> index 6c6856e..ea0ae62 100644
> --- a/package/elfutils/Config.in
> +++ b/package/elfutils/Config.in
> @@ -4,7 +4,7 @@ comment "elfutils needs a toolchain w/ wchar, dynamic library"
>  
>  config BR2_PACKAGE_ELFUTILS
>  	bool "elfutils"
> -	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
> +	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL

Ditto, you also need to adjust the build dependencies in the .mk .

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
>  	depends on BR2_USE_WCHAR
>  	depends on !BR2_STATIC_LIBS
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni Aug. 3, 2015, 9:15 a.m. UTC | #2
Dear Romain Naour,

On Sat,  1 Aug 2015 18:55:17 +0200, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/elfutils/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/elfutils/Config.in b/package/elfutils/Config.in
> index 6c6856e..ea0ae62 100644
> --- a/package/elfutils/Config.in
> +++ b/package/elfutils/Config.in
> @@ -4,7 +4,7 @@ comment "elfutils needs a toolchain w/ wchar, dynamic library"
>  
>  config BR2_PACKAGE_ELFUTILS
>  	bool "elfutils"
> -	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
> +	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL

This is not sufficient to get elfutils to build with musl. Lots of
other changes are needed (TEMP_FAILURE_RETRY, <error.h>, etc.).

Thomas
diff mbox

Patch

diff --git a/package/elfutils/Config.in b/package/elfutils/Config.in
index 6c6856e..ea0ae62 100644
--- a/package/elfutils/Config.in
+++ b/package/elfutils/Config.in
@@ -4,7 +4,7 @@  comment "elfutils needs a toolchain w/ wchar, dynamic library"
 
 config BR2_PACKAGE_ELFUTILS
 	bool "elfutils"
-	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
+	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
 	depends on BR2_USE_WCHAR
 	depends on !BR2_STATIC_LIBS