| Message ID | 1438362152-11865-1-git-send-email-manabian@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Joachim Eastwood <manabian@gmail.com> Date: Fri, 31 Jul 2015 19:02:32 +0200 > Commit 50649ab14982 ("stmmac: drop driver from stmmac platform code") > was a bit overzealous in removing code and dropped the MODULE_* > macro's that are still needed since stmmac_platform can be a module. > Fix this by putting the macro's remvoed in 50649ab14982 back. > > This fixes the following errors when used as a module: > stmmac_platform: module license 'unspecified' taints kernel. > Disabling lock debugging due to kernel taint > stmmac_platform: Unknown symbol devm_kmalloc (err 0) > stmmac_platform: Unknown symbol stmmac_suspend (err 0) > stmmac_platform: Unknown symbol platform_get_irq_byname (err 0) > stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0) > stmmac_platform: Unknown symbol platform_get_resource (err 0) > stmmac_platform: Unknown symbol of_get_phy_mode (err 0) > stmmac_platform: Unknown symbol of_property_read_u32_array (err 0) > stmmac_platform: Unknown symbol of_alias_get_id (err 0) > stmmac_platform: Unknown symbol stmmac_resume (err 0) > stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0) > > Fixes: 50649ab14982 ("stmmac: drop driver from stmmac platform code") > Reported-by: Igor Gnatenko <i.gnatenko.brain@gmail.com> > Signed-off-by: Joachim Eastwood <manabian@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index f3918c7e7eeb..bcdc8955c719 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -413,3 +413,7 @@ static int stmmac_pltfr_resume(struct device *dev) SIMPLE_DEV_PM_OPS(stmmac_pltfr_pm_ops, stmmac_pltfr_suspend, stmmac_pltfr_resume); EXPORT_SYMBOL_GPL(stmmac_pltfr_pm_ops); + +MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet platform support"); +MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>"); +MODULE_LICENSE("GPL");
Commit 50649ab14982 ("stmmac: drop driver from stmmac platform code") was a bit overzealous in removing code and dropped the MODULE_* macro's that are still needed since stmmac_platform can be a module. Fix this by putting the macro's remvoed in 50649ab14982 back. This fixes the following errors when used as a module: stmmac_platform: module license 'unspecified' taints kernel. Disabling lock debugging due to kernel taint stmmac_platform: Unknown symbol devm_kmalloc (err 0) stmmac_platform: Unknown symbol stmmac_suspend (err 0) stmmac_platform: Unknown symbol platform_get_irq_byname (err 0) stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0) stmmac_platform: Unknown symbol platform_get_resource (err 0) stmmac_platform: Unknown symbol of_get_phy_mode (err 0) stmmac_platform: Unknown symbol of_property_read_u32_array (err 0) stmmac_platform: Unknown symbol of_alias_get_id (err 0) stmmac_platform: Unknown symbol stmmac_resume (err 0) stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0) Fixes: 50649ab14982 ("stmmac: drop driver from stmmac platform code") Reported-by: Igor Gnatenko <i.gnatenko.brain@gmail.com> Signed-off-by: Joachim Eastwood <manabian@gmail.com> --- Hi, An alternative solution could be to change CONFIG_STMMAC_PLATFORM into a bool, but I guess we want to keep things as modular as possible. Please test this Igor and report back. Thanks! drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 ++++ 1 file changed, 4 insertions(+)