diff mbox

[RFC,10/10] maint: enable checking for qemu/osdep.h header usage

Message ID 1438360263-25445-11-git-send-email-berrange@redhat.com
State New
Headers show

Commit Message

Daniel P. Berrangé July 31, 2015, 4:31 p.m. UTC
Uncomment rules which mandate that qemu/osdep.h is included
in all .c file, and that it appears in the file before any
other includes.

NB, this change isn't intended to be applied as it obviously
fails. It is just an illustration of how we'd enforce such
a header usage rule.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 cfg.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/cfg.mk b/cfg.mk
index 2f98c1a..da420c0 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -63,8 +63,6 @@  local-checks-to-skip =			\
   sc_prohibit_test_double_equal		\
   sc_prohibit_test_minus_ao		\
   sc_prohibit_undesirable_word_seq	\
-  sc_require_config_h			\
-  sc_require_config_h_first		\
   sc_require_test_exit_idiom		\
   sc_root_tests				\
   sc_space_tab				\
@@ -80,6 +78,8 @@  local-checks-to-skip =			\
   sc_Wundef_boolean			\
   $(NULL)
 
+config_h_header ?= "qemu/osdep\.h"
+
 # Files that should never cause syntax check failures.
 VC_LIST_ALWAYS_EXCLUDE_REGEX = \
   (^HACKING|\.po|^maint\.mk|^cfg\.mk|^pc-bios/.*)$$