From patchwork Thu Apr 15 13:11:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: qcow2: Use QLIST_FOREACH_SAFE macro Date: Thu, 15 Apr 2010 03:11:35 -0000 From: Stefan Hajnoczi X-Patchwork-Id: 50242 Message-Id: <1271337095-4727-1-git-send-email-stefanha@linux.vnet.ibm.com> To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- block/qcow2.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 11ce8d1..9b986ae 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -539,14 +539,8 @@ static void run_dependent_requests(QCowL2Meta *m) QLIST_REMOVE(m, next_in_flight); } - /* - * Restart all dependent requests. - * Can't use QLIST_FOREACH here - the next link might not be the same - * any more after the callback (request could depend on a different - * request now) - */ - for (req = m->dependent_requests.lh_first; req != NULL; req = next) { - next = req->next_depend.le_next; + /* Restart all dependent requests */ + QLIST_FOREACH_SAFE(req, &m->dependent_requests, next_depend, next) { qcow_aio_write_cb(req, 0); }