Message ID | 1271322674-21726-1-git-send-email-daniel.lezcano@free.fr |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Daniel Lezcano wrote: > The af_packet protocol is used by Perl to do ioctls as reported by > Stephane Riviere: > > "Net::RawIP relies on SIOCGIFADDR et SIOCGIFHWADDR to get the IP and MAC > addresses of the network interface." > > But in a new network namespace these ioctl fail because it is disabled for > a namespace different from the init_net_ns. > > These two lines should not be there as af_inet and af_packet are > namespace aware since a long time now. I suppose we forget to remove these > lines because we sent the af_packet first, before af_inet was supported. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr> > Reported-by: Stephane Riviere <stephane.riviere@regis-dgac.net> > --- > net/packet/af_packet.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > index cc90363..243946d 100644 > --- a/net/packet/af_packet.c > +++ b/net/packet/af_packet.c > @@ -2169,8 +2169,6 @@ static int packet_ioctl(struct socket *sock, unsigned int cmd, > case SIOCGIFDSTADDR: > case SIOCSIFDSTADDR: > case SIOCSIFFLAGS: > - if (!net_eq(sock_net(sk), &init_net)) > - return -ENOIOCTLCMD; > return inet_dgram_ops.ioctl(sock, cmd, arg); > #endif > > Shall I send it against net-next-2.6 ? Thanks -- Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Daniel Lezcano <daniel.lezcano@free.fr> Date: Fri, 16 Apr 2010 17:04:28 +0200 > Shall I send it against net-next-2.6 ? No, I'll likely add it to net-2.6, I just haven't gotten around to it yet. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Daniel Lezcano <daniel.lezcano@free.fr> Date: Thu, 15 Apr 2010 11:11:14 +0200 > The af_packet protocol is used by Perl to do ioctls as reported by > Stephane Riviere: > > "Net::RawIP relies on SIOCGIFADDR et SIOCGIFHWADDR to get the IP and MAC > addresses of the network interface." > > But in a new network namespace these ioctl fail because it is disabled for > a namespace different from the init_net_ns. > > These two lines should not be there as af_inet and af_packet are > namespace aware since a long time now. I suppose we forget to remove these > lines because we sent the af_packet first, before af_inet was supported. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr> > Reported-by: Stephane Riviere <stephane.riviere@regis-dgac.net> Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index cc90363..243946d 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -2169,8 +2169,6 @@ static int packet_ioctl(struct socket *sock, unsigned int cmd, case SIOCGIFDSTADDR: case SIOCSIFDSTADDR: case SIOCSIFFLAGS: - if (!net_eq(sock_net(sk), &init_net)) - return -ENOIOCTLCMD; return inet_dgram_ops.ioctl(sock, cmd, arg); #endif
The af_packet protocol is used by Perl to do ioctls as reported by Stephane Riviere: "Net::RawIP relies on SIOCGIFADDR et SIOCGIFHWADDR to get the IP and MAC addresses of the network interface." But in a new network namespace these ioctl fail because it is disabled for a namespace different from the init_net_ns. These two lines should not be there as af_inet and af_packet are namespace aware since a long time now. I suppose we forget to remove these lines because we sent the af_packet first, before af_inet was supported. Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr> Reported-by: Stephane Riviere <stephane.riviere@regis-dgac.net> --- net/packet/af_packet.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)