Message ID | 4BC6D705.80601@jp.fujitsu.com |
---|---|
State | Awaiting Upstream, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, Apr 15, 2010 at 02:06, Koki Sanagi <sanagi.koki@jp.fujitsu.com> wrote: > Previous patch has some mail format problem. > Maybe I've fixed and re-sent. > > There is no need to increment nr_frags becasue skb_fill_page_desc increments > it. > > Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com> > --- > drivers/net/igb/igb_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Thanks, I have added the patch to my queue of patches.
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index 78cc742..8bde6c3 100644 --- a/drivers/net/igb/igb_main.c +++ b/drivers/net/igb/igb_main.c @@ -5254,7 +5254,7 @@ static bool igb_clean_rx_irq_adv(struct igb_q_vector *q_vector, PAGE_SIZE / 2, PCI_DMA_FROMDEVICE); buffer_info->page_dma = 0; - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++, + skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags, buffer_info->page, buffer_info->page_offset, length);
Previous patch has some mail format problem. Maybe I've fixed and re-sent. There is no need to increment nr_frags becasue skb_fill_page_desc increments it. Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com> --- drivers/net/igb/igb_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html