| Message ID | 4BC6BEFC.3010309@jp.fujitsu.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
2010/4/15 Koki Sanagi <sanagi.koki@jp.fujitsu.com>: > There is no need to increment nr_frags becasue skb_fill_page_desc increments > it. > > Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com> > --- > drivers/net/igbvf/netdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Thanks I have added this patch to my queue of patches.
diff --git a/drivers/net/igbvf/netdev.c b/drivers/net/igbvf/netdev.c index ea8abf5..97cfc60 100644 --- a/drivers/net/igbvf/netdev.c +++ b/drivers/net/igbvf/netdev.c @@ -288,7 +288,7 @@ static bool igbvf_clean_rx_irq(struct igbvf_adapter *adapter, PCI_DMA_FROMDEVICE); buffer_info->page_dma = 0; - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++, + skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags, buffer_info->page, buffer_info->page_offset, length);
There is no need to increment nr_frags becasue skb_fill_page_desc increments it. Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com> --- drivers/net/igbvf/netdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html