Patchwork pcf8563: remove unused struct.

login
register
mail settings
Submitter Graham Gower
Date April 15, 2010, 5:12 a.m.
Message ID <4BC6A020.7050008@gmail.com>
Download mbox | patch
Permalink /patch/50216/
State New
Headers show

Comments

Graham Gower - April 15, 2010, 5:12 a.m.
Signed-off-by: Graham Gower <graham.gower@gmail.com>
---
 drivers/rtc/rtc-pcf8563.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
Wan ZongShun - May 27, 2010, 7:23 a.m.
2010/4/15 Graham Gower <graham.gower@gmail.com>:
>
>
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
> ---
>  drivers/rtc/rtc-pcf8563.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
> index 65f346b..e7ae8b4 100644
> --- a/drivers/rtc/rtc-pcf8563.c
> +++ b/drivers/rtc/rtc-pcf8563.c
> @@ -171,14 +171,6 @@ static int pcf8563_set_datetime(struct i2c_client *client, struct rtc_time *tm)
>        return 0;
>  }
>
> -struct pcf8563_limit
> -{
> -       unsigned char reg;
> -       unsigned char mask;
> -       unsigned char min;
> -       unsigned char max;
> -};
> -

It is really unwanted, tested by me.

Acked-by: Wan ZongShun<mcuos.com@gmail.com>


>  static int pcf8563_rtc_read_time(struct device *dev, struct rtc_time *tm)
>  {
>        return pcf8563_get_datetime(to_i2c_client(dev), tm);
>
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
>
> To unsubscribe, reply using "remove me" as the subject.
>
Andrew Morton - June 1, 2010, 10:45 p.m.
On Thu, 27 May 2010 15:23:17 +0800
Wan ZongShun <mcuos.com@gmail.com> wrote:

> 2010/4/15 Graham Gower <graham.gower@gmail.com>:
> >
> >
> > Signed-off-by: Graham Gower <graham.gower@gmail.com>
> > ---
> > __drivers/rtc/rtc-pcf8563.c | __ __8 --------
> > __1 files changed, 0 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
> > index 65f346b..e7ae8b4 100644
> > --- a/drivers/rtc/rtc-pcf8563.c
> > +++ b/drivers/rtc/rtc-pcf8563.c
> > @@ -171,14 +171,6 @@ static int pcf8563_set_datetime(struct i2c_client *client, struct rtc_time *tm)
> > __ __ __ __return 0;
> > __}
> >
> > -struct pcf8563_limit
> > -{
> > - __ __ __ unsigned char reg;
> > - __ __ __ unsigned char mask;
> > - __ __ __ unsigned char min;
> > - __ __ __ unsigned char max;
> > -};
> > -
> 
> It is really unwanted, tested by me.
> 
> Acked-by: Wan ZongShun<mcuos.com@gmail.com>
> 

I'm not actually subscribed to the rtc-linux list, so I don't have a
copy of this patch.
Andrew Morton - June 1, 2010, 10:46 p.m.
(grr, why wasn't Graham cc'ed)?

On Thu, 27 May 2010 15:23:17 +0800
Wan ZongShun <mcuos.com@gmail.com> wrote:

> 2010/4/15 Graham Gower <graham.gower@gmail.com>:
> >
> >
> > Signed-off-by: Graham Gower <graham.gower@gmail.com>
> > ---
> > __drivers/rtc/rtc-pcf8563.c | __ __8 --------
> > __1 files changed, 0 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
> > index 65f346b..e7ae8b4 100644
> > --- a/drivers/rtc/rtc-pcf8563.c
> > +++ b/drivers/rtc/rtc-pcf8563.c
> > @@ -171,14 +171,6 @@ static int pcf8563_set_datetime(struct i2c_client *client, struct rtc_time *tm)
> > __ __ __ __return 0;
> > __}
> >
> > -struct pcf8563_limit
> > -{
> > - __ __ __ unsigned char reg;
> > - __ __ __ unsigned char mask;
> > - __ __ __ unsigned char min;
> > - __ __ __ unsigned char max;
> > -};
> > -
> 
> It is really unwanted, tested by me.
> 
> Acked-by: Wan ZongShun<mcuos.com@gmail.com>

I'm not actually subscribed to the rtc-linux list, so I don't have a
copy of this patch.

Patch

diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
index 65f346b..e7ae8b4 100644
--- a/drivers/rtc/rtc-pcf8563.c
+++ b/drivers/rtc/rtc-pcf8563.c
@@ -171,14 +171,6 @@  static int pcf8563_set_datetime(struct i2c_client *client, struct rtc_time *tm)
 	return 0;
 }
 
-struct pcf8563_limit
-{
-	unsigned char reg;
-	unsigned char mask;
-	unsigned char min;
-	unsigned char max;
-};
-
 static int pcf8563_rtc_read_time(struct device *dev, struct rtc_time *tm)
 {
 	return pcf8563_get_datetime(to_i2c_client(dev), tm);