From patchwork Wed Apr 14 18:07:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [16/21] tcg-i386: Tidy setcc. From: Richard Henderson X-Patchwork-Id: 50196 Message-Id: To: qemu-devel@nongnu.org Cc: aurelien@aurel32.net Date: Wed, 14 Apr 2010 11:07:27 -0700 Define and use OPC_SETCC. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 376ac7b..af051b0 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -189,6 +189,7 @@ static inline int tcg_target_const_match(tcg_target_long val, #define OPC_PUSH_Iv (0x68) #define OPC_PUSH_Ib (0x6a) #define OPC_RET (0xc3) +#define OPC_SETCC (0x90 | P_EXT) /* ... plus condition code */ #define OPC_SHIFT_1 (0xd1) #define OPC_SHIFT_Ib (0xc1) #define OPC_SHIFT_cl (0xd3) @@ -603,8 +604,7 @@ static void tcg_out_setcond(TCGContext *s, TCGCond cond, TCGArg dest, TCGArg arg1, TCGArg arg2, int const_arg2) { tcg_out_cmp(s, arg1, arg2, const_arg2); - /* setcc */ - tcg_out_modrm(s, 0x90 | tcg_cond_to_jcc[cond] | P_EXT, 0, dest); + tcg_out_modrm(s, OPC_SETCC | tcg_cond_to_jcc[cond], 0, dest); tcg_out_ext8u(s, dest, dest); }