From patchwork Wed Apr 14 18:08:48 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/2] mount.cifs: check for NULL pointer before calling strchr() From: Jeff Layton X-Patchwork-Id: 50174 Message-Id: <1271268529-462-1-git-send-email-jlayton@samba.org> To: linux-cifs-client@lists.samba.org Date: Wed, 14 Apr 2010 14:08:48 -0400 mount.cifs calls strchr on currentaddress, which may be a NULL pointer. Signed-off-by: Jeff Layton --- mount.cifs.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/mount.cifs.c b/mount.cifs.c index acab8c8..f3aa464 100644 --- a/mount.cifs.c +++ b/mount.cifs.c @@ -1730,9 +1730,11 @@ mount_retry: case ECONNREFUSED: case EHOSTUNREACH: currentaddress = nextaddress; - nextaddress = strchr(currentaddress, ','); - if (nextaddress) - *nextaddress++ = '\0'; + if (currentaddress) { + nextaddress = strchr(currentaddress, ','); + if (nextaddress) + *nextaddress++ = '\0'; + } goto mount_retry; case ENODEV: fprintf(stderr,